Re: [PATCH] staging: rtl8723bs: replace beacon timing magic numbers with named constants

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Jul 08, 2026 at 03:36:23PM +0100, Jad Keskes wrote:
> On 07/08, Greg KH wrote:
> > On Wed, Jul 08, 2026 at 03:17:02PM +0100, Jad Keskes wrote:
> > 
> > <snip>
> > 
> > For some reason you sent this only to me, which is a bit rude to
> > everyone else on the mailing list.  I'll be glad to respond if you
> > resend it to everyone.
> > 
> > thanks,
> > 
> > greg k-h
> 
> Apologies, meant to send that to the list. Resending:
> 
> Yeah, that info is from the out-of-tree driver Dan linked in the TODO thread.  

What thread?  Point to it please in the changelog.

> REG_TBTT_PROHIBIT has the same hold/setup layout as rtw88's WLAN_TBTT_HOLD_TIME / WLAN_TBTT_PROHIBIT.
> 
> REG_BCNTCFG — check rtl8192cu in the tree. Same register, same 0x66 CW byte. 
> Production writes 0x660F, test chips write 0x66FF. Only the AIFS changes.

Great, document this and where you got the info from in the changelog so
that it doesn't look like you just made it up out of the air :)

thanks,

greg k-h