From: Dan Carpenter <error27@gmail.com>
To: Jad Keskes <inasj268@gmail.com>
Cc: linux-staging@lists.linux.dev,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: replace magic numbers with named constants
Date: Thu, 4 Jun 2026 17:34:21 +0300 [thread overview]
Message-ID: <aiGM7ViQ9Ee_JY_T@stanley.mountain> (raw)
In-Reply-To: <aiGMXBNQ0TbIGbpP@stanley.mountain>
On Thu, Jun 04, 2026 at 05:31:56PM +0300, Dan Carpenter wrote:
> On Wed, Jun 03, 2026 at 03:31:27PM +0100, Jad Keskes wrote:
> > Remove the magic numbers in rtl8723b_InitBeaconParameters() as requested
> > by the outstanding TODO comment. Replace 0x6404 and 0x660F with named
> > constants defined in rtl8723b_hal.h alongside the existing beacon timing
> > constants.
> >
> > Signed-off-by: Jad Keskes <inasj268@gmail.com>
>
> Just having the same define but as a goto doesn't add any information
> or value.
Ugh... Sorry, I meant to say "just having the same value but as a define
doesn't add any information."
regards,
dan carpenter
next prev parent reply other threads:[~2026-06-04 14:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 14:31 [PATCH] staging: rtl8723bs: replace magic numbers with named constants Jad Keskes
2026-06-04 14:31 ` Dan Carpenter
2026-06-04 14:34 ` Dan Carpenter [this message]
2026-06-04 15:18 ` [PATCH] staging: rtl8723bs: replace beacon timing " Jad Keskes
-- strict thread matches above, loose matches on Subject: below --
2026-04-11 5:28 [PATCH] staging: rtl8723bs: replace " Adith-Joshua
2026-04-11 8:07 ` Dan Carpenter
2026-04-11 17:20 ` Luka Gejak
[not found] ` <CAFvcH2CjS=HMxt_Dd04eMAELQtxdB5LYmLa_1TLnJeEuKvR6=Q@mail.gmail.com>
2026-04-12 12:57 ` Dan Carpenter
[not found] ` <CAFvcH2DQJtB6B9L+SMgg_aPXGe96hw2i6+C1N0uhapHvJQHd2w@mail.gmail.com>
2026-04-13 5:41 ` Dan Carpenter
2026-04-11 17:15 ` Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiGM7ViQ9Ee_JY_T@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=inasj268@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox