From: Greg KH <gregkh@linuxfoundation.org>
To: Akhmad <akhmad100913@gmail.com>
Cc: linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8723bs: replace magic numbers with named constants
Date: Tue, 28 Jul 2026 09:33:57 +0200 [thread overview]
Message-ID: <2026072833-scoundrel-deodorize-2dda@gregkh> (raw)
In-Reply-To: <20260725125314.39313-1-Akhmad100913@gmail.com>
On Sat, Jul 25, 2026 at 03:53:14PM +0300, Akhmad wrote:
> Replace magic numbers 0x6404 and 0x660F in rtl8723b_InitBeaconVariables()
> with named constants TBTT_PROHIBIT_INIT_VAL and BCNTCFG_INIT_VAL.
Where did these magic constant names come from? Please always document
that.
> This improves code readability and addresses a TODO comment requesting
> the removal of magic numbers from this driver.
>
> Signed-off-by: Akhmad <Akhmad100913@gmail.com>
Your full name please.
thanks,
greg k-h
next prev parent reply other threads:[~2026-07-28 7:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-25 12:53 [PATCH] staging: rtl8723bs: replace magic numbers with named constants Akhmad
2026-07-28 7:33 ` Greg KH [this message]
[not found] ` <CACCSLCopDTUV2G9JG8yCuRnUYaOvCeNY-SHEC+xzv3kOJ3S2eg@mail.gmail.com>
2026-07-28 8:38 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2026-06-03 14:31 Jad Keskes
2026-06-04 14:31 ` Dan Carpenter
2026-06-04 14:34 ` Dan Carpenter
2026-04-11 5:28 Adith-Joshua
2026-04-11 8:07 ` Dan Carpenter
2026-04-11 17:20 ` Luka Gejak
[not found] ` <CAFvcH2CjS=HMxt_Dd04eMAELQtxdB5LYmLa_1TLnJeEuKvR6=Q@mail.gmail.com>
2026-04-12 12:57 ` Dan Carpenter
[not found] ` <CAFvcH2DQJtB6B9L+SMgg_aPXGe96hw2i6+C1N0uhapHvJQHd2w@mail.gmail.com>
2026-04-13 5:41 ` Dan Carpenter
2026-04-11 17:15 ` Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026072833-scoundrel-deodorize-2dda@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akhmad100913@gmail.com \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox