[PATCH] staging: rtl8723bs: rename camelcase variable bDumpRxPkt

[PATCH] staging: rtl8723bs: rename camelcase variable bDumpRxPkt

[Anirban Bose]

Rename the local variable 'bDumpRxPkt' to 'dump_rx_pkt' in
validate_recv_frame() to resolve a checkpatch.pl CamelCase warning.

Signed-off-by: Anirban Bose <boses156@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index 86c5e2c4e7dd..808f67b61f77 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -1447,7 +1447,7 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
 	u8 type;
 	u8 subtype;
 	signed int retval = _SUCCESS;
-	u8 bDumpRxPkt;
+	u8 dump_rx_pkt;
 
 	struct rx_pkt_attrib *pattrib = &precv_frame->u.hdr.attrib;
 
@@ -1473,7 +1473,7 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
 	pattrib->mdata = GetMData(ptr);
 	pattrib->privacy = GetPrivacy(ptr);
 	pattrib->order = GetOrder(ptr);
-	rtw_hal_get_def_var(adapter, HAL_DEF_DBG_DUMP_RXPKT, &(bDumpRxPkt));
+	rtw_hal_get_def_var(adapter, HAL_DEF_DBG_DUMP_RXPKT, &(dump_rx_pkt));
 
 	switch (type) {
 	case WIFI_MGT_TYPE: /* mgnt */
-- 
2.54.0

Re: [PATCH] staging: rtl8723bs: rename camelcase variable bDumpRxPkt

[Greg KH]

On Mon, May 25, 2026 at 12:29:35PM +0530, Anirban Bose wrote:
> Rename the local variable 'bDumpRxPkt' to 'dump_rx_pkt' in
> validate_recv_frame() to resolve a checkpatch.pl CamelCase warning.
> 
> Signed-off-by: Anirban Bose <boses156@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_recv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index 86c5e2c4e7dd..808f67b61f77 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -1447,7 +1447,7 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
>  	u8 type;
>  	u8 subtype;
>  	signed int retval = _SUCCESS;
> -	u8 bDumpRxPkt;
> +	u8 dump_rx_pkt;
>  
>  	struct rx_pkt_attrib *pattrib = &precv_frame->u.hdr.attrib;
>  
> @@ -1473,7 +1473,7 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
>  	pattrib->mdata = GetMData(ptr);
>  	pattrib->privacy = GetPrivacy(ptr);
>  	pattrib->order = GetOrder(ptr);
> -	rtw_hal_get_def_var(adapter, HAL_DEF_DBG_DUMP_RXPKT, &(bDumpRxPkt));
> +	rtw_hal_get_def_var(adapter, HAL_DEF_DBG_DUMP_RXPKT, &(dump_rx_pkt));

If this is never used, why is it set at all?

thanks,

greg k-h

[PATCH v2] staging: rtl8723bs: remove unused variable bDumpRxPkt

[Anirban Bose]

The 'bDumpRxPkt' variable is declared validate_recv_frame() function and
some debug information is written into it by rtw_hal_get_def_var() but
as I have checked it, it is not used anywhere else in the function so
its basically a useless variable now.

I have remove the variable and its assignment in the function.

Signed-off-by: Anirban Bose <boses156@gmail.com>
---
v2:
  - I removed it after checking it as pointed out by greg, instead of
    renaming it
---
 drivers/staging/rtl8723bs/core/rtw_recv.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index 6bb119a83036..2f6c9967805c 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -1447,7 +1447,6 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
 	u8 type;
 	u8 subtype;
 	signed int retval = _SUCCESS;
-	u8 bDumpRxPkt;
 
 	struct rx_pkt_attrib *pattrib = &precv_frame->u.hdr.attrib;
 
@@ -1473,7 +1472,6 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
 	pattrib->mdata = GetMData(ptr);
 	pattrib->privacy = GetPrivacy(ptr);
 	pattrib->order = GetOrder(ptr);
-	rtw_hal_get_def_var(adapter, HAL_DEF_DBG_DUMP_RXPKT, &(bDumpRxPkt));
 
 	switch (type) {
 	case WIFI_MGT_TYPE: /* mgnt */
-- 
2.53.0