* [PATCH v4] staging: rtl8723bs: remove redundant ReadChipVersion8723B wrapper
@ 2026-07-16 10:33 Arsenii Pashchenko
2026-07-17 12:10 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Arsenii Pashchenko @ 2026-07-16 10:33 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, ulijg308
Collapse the static CamelCase helper function ReadChipVersion8723B()
directly into the main rtl8723b_read_chip_version() function.
This removes unnecessary code nesting and cleans up the CamelCase
naming violation in a single atomic change.
---
Changes in v4:
- Format patch via b4 as suggested by Greg (no code changes).
Changes in v3:
- Merged the previous 2-patch series into a single patch as suggested
by Nikolay. Completely removed the redundant helper instead of
renaming it with '__' prefixes.
Changes in v2:
- Resent the series due to submission issues with v1 (no code changes).
Signed-off-by: Arsenii Pashchenko <ulijg308@gmail.com>
---
Arsenii Pashchenko (1):
staging: rtl8723bs: remove redundant ReadChipVersion8723B wrapper
---
base-commit: 4d4ac249a4f992a9c77c5187bb795f1e888d9614
change-id: 20260716-remove-readchipversion8723b-wrapper-16b9d8f2aaed
Best regards,
--
Arsenii Pashchenko <ulijg308@gmail.com>
---
---
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v4] staging: rtl8723bs: remove redundant ReadChipVersion8723B wrapper
2026-07-16 10:33 [PATCH v4] staging: rtl8723bs: remove redundant ReadChipVersion8723B wrapper Arsenii Pashchenko
@ 2026-07-17 12:10 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2026-07-17 12:10 UTC (permalink / raw)
To: Arsenii Pashchenko; +Cc: linux-staging, linux-kernel
On Thu, Jul 16, 2026 at 05:33:10PM +0700, Arsenii Pashchenko wrote:
> Collapse the static CamelCase helper function ReadChipVersion8723B()
> directly into the main rtl8723b_read_chip_version() function.
> This removes unnecessary code nesting and cleans up the CamelCase
> naming violation in a single atomic change.
>
> ---
> Changes in v4:
> - Format patch via b4 as suggested by Greg (no code changes).
>
> Changes in v3:
> - Merged the previous 2-patch series into a single patch as suggested
> by Nikolay. Completely removed the redundant helper instead of
> renaming it with '__' prefixes.
>
> Changes in v2:
> - Resent the series due to submission issues with v1 (no code changes).
>
> Signed-off-by: Arsenii Pashchenko <ulijg308@gmail.com>
The changelog goes below the only --- line, and the signed-off-by goes
above it.
Try using the b4 tool for all of this, it should handle it for you
automatically.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-17 12:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-16 10:33 [PATCH v4] staging: rtl8723bs: remove redundant ReadChipVersion8723B wrapper Arsenii Pashchenko
2026-07-17 12:10 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox