From: Prajval Chaudhary <prajvalchaudhari733@gmail.com>
To: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andy Shevchenko <andy@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Prajval Chaudhary <prajvalchaudhari733@gmail.com>
Subject: [PATCH 1/2] staging: media: atomisp: Remove unused and unwanted debug module parameters
Date: Sun, 19 Jul 2026 19:33:49 +0530 [thread overview]
Message-ID: <20260719140350.8266-2-prajvalchaudhari733@gmail.com> (raw)
In-Reply-To: <20260719140350.8266-1-prajvalchaudhari733@gmail.com>
Remove the unused module parameters 'dbg_level' and 'dbg_func'.
Additionally, remove the 'pad_w' and 'pad_h' module parameters
to prevent userspace from overriding internal ISP hardware padding
boundaries, leaving them as internal driver constants.
This addresses the 'Remove unnecessary/unwanted module parameters'
task in the driver's TODO file.
Signed-off-by: Prajval Chaudhary <prajvalchaudhari733@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 15 ---------------
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
index 812230397409..5c2f5996a03f 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
@@ -44,17 +44,6 @@
/* G-Min addition: pull this in from intel_mid_pm.h */
#define CSTATE_EXIT_LATENCY_C1 1
-/* cross component debug message flag */
-int dbg_level;
-module_param(dbg_level, int, 0644);
-MODULE_PARM_DESC(dbg_level, "debug message level (default:0)");
-
-/* log function switch */
-int dbg_func = 1;
-module_param(dbg_func, int, 0644);
-MODULE_PARM_DESC(dbg_func,
- "log function switch non/printk (default:printk)");
-
/*
* Set to 16x16 since this is the amount of lines and pixels the sensor
* exports extra. If these are kept at the 10x8 that they were on, in yuv
@@ -65,12 +54,8 @@ MODULE_PARM_DESC(dbg_func,
* the chosen solution is the next best thing.
*/
int pad_w = 16;
-module_param(pad_w, int, 0644);
-MODULE_PARM_DESC(pad_w, "extra data for ISP processing");
int pad_h = 16;
-module_param(pad_h, int, 0644);
-MODULE_PARM_DESC(pad_h, "extra data for ISP processing");
/*
* FIXME: this is a hack to make easier to support ISP2401 variant.
--
2.34.1
next prev parent reply other threads:[~2026-07-19 14:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 14:03 [PATCH 0/2] staging: media: atomisp: Clean up unnecessary module parameters Prajval Chaudhary
2026-07-19 14:03 ` Prajval Chaudhary [this message]
2026-07-19 17:05 ` [PATCH 1/2] staging: media: atomisp: Remove unused and unwanted debug " Andy Shevchenko
2026-07-20 10:38 ` Dan Carpenter
2026-07-20 10:59 ` Andy Shevchenko
2026-07-19 14:03 ` [PATCH 2/2] staging: media: atomisp: Mark pad_w and pad_h as const constants Prajval Chaudhary
2026-07-19 17:02 ` [PATCH 0/2] staging: media: atomisp: Clean up unnecessary module parameters Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260719140350.8266-2-prajvalchaudhari733@gmail.com \
--to=prajvalchaudhari733@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox