From: Dan Carpenter <error27@gmail.com>
To: Prajval Chaudhary <prajvalchaudhari733@gmail.com>
Cc: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andy@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: media: atomisp: Remove unused and unwanted debug module parameters
Date: Mon, 20 Jul 2026 13:38:01 +0300 [thread overview]
Message-ID: <al36id6uaqTB404p@stanley.mountain> (raw)
In-Reply-To: <20260719140350.8266-2-prajvalchaudhari733@gmail.com>
On Sun, Jul 19, 2026 at 07:33:49PM +0530, Prajval Chaudhary wrote:
> Remove the unused module parameters 'dbg_level' and 'dbg_func'.
> Additionally, remove the 'pad_w' and 'pad_h' module parameters
> to prevent userspace from overriding internal ISP hardware padding
> boundaries, leaving them as internal driver constants.
>
> This addresses the 'Remove unnecessary/unwanted module parameters'
> task in the driver's TODO file.
>
> Signed-off-by: Prajval Chaudhary <prajvalchaudhari733@gmail.com>
> ---
It's weird that the driver still has lots of references to these varaibles
but the build didn't break for me...
regards,
dan carpenter
next prev parent reply other threads:[~2026-07-20 10:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 14:03 [PATCH 0/2] staging: media: atomisp: Clean up unnecessary module parameters Prajval Chaudhary
2026-07-19 14:03 ` [PATCH 1/2] staging: media: atomisp: Remove unused and unwanted debug " Prajval Chaudhary
2026-07-19 17:05 ` Andy Shevchenko
2026-07-20 10:38 ` Dan Carpenter [this message]
2026-07-20 10:59 ` Andy Shevchenko
2026-07-19 14:03 ` [PATCH 2/2] staging: media: atomisp: Mark pad_w and pad_h as const constants Prajval Chaudhary
2026-07-19 17:02 ` [PATCH 0/2] staging: media: atomisp: Clean up unnecessary module parameters Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al36id6uaqTB404p@stanley.mountain \
--to=error27@gmail.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=prajvalchaudhari733@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox