[PATCH] staging: rtl8723bs: replace yield() with cond_resched()

[PATCH] staging: rtl8723bs: replace yield() with cond_resched()

[Akhmad]

From: Akhmad Zubairugadzhiev <Akhmad100913@gmail.com>

Replace deprecated yield() calls with cond_resched() in
rtl8723b_hal_init.c. The yield() function is considered
wrong practice in kernel code as it can lead to unexpected
behavior. cond_resched() is the recommended replacement
for conditional rescheduling in polling loops.

Signed-off-by: Akhmad Zubairugadzhiev <Akhmad100913@gmail.com>
---
 drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index bcaf63b28..6fc3774d2 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -191,7 +191,7 @@ static s32 polling_fwdl_chksum(
 		value32 = rtw_read32(adapter, REG_MCUFWDL);
 		if (value32 & FWDL_ChkSum_rpt || adapter->bSurpriseRemoved || adapter->bDriverStopped)
 			break;
-		yield();
+		cond_resched();
 	} while (jiffies_to_msecs(jiffies-start) < timeout_ms || cnt < min_cnt);
 
 	if (!(value32 & FWDL_ChkSum_rpt)) {
@@ -232,7 +232,7 @@ static s32 _FWFreeToGo(struct adapter *adapter, u32 min_cnt, u32 timeout_ms)
 		value32 = rtw_read32(adapter, REG_MCUFWDL);
 		if (value32 & WINTINI_RDY || adapter->bSurpriseRemoved || adapter->bDriverStopped)
 			break;
-		yield();
+		cond_resched();
 	} while (jiffies_to_msecs(jiffies - start) < timeout_ms || cnt < min_cnt);
 
 	if (!(value32 & WINTINI_RDY)) {
-- 
2.37.1 (Apple Git-137.1)

Re: [PATCH] staging: rtl8723bs: replace yield() with cond_resched()

[Greg KH]

On Sat, Jul 25, 2026 at 09:18:37PM +0300, Akhmad wrote:
> From: Akhmad Zubairugadzhiev <Akhmad100913@gmail.com>
> 
> Replace deprecated yield() calls with cond_resched() in
> rtl8723b_hal_init.c. The yield() function is considered
> wrong practice in kernel code as it can lead to unexpected
> behavior. cond_resched() is the recommended replacement
> for conditional rescheduling in polling loops.

What "unexpected behavior" can happen here?

> 
> Signed-off-by: Akhmad Zubairugadzhiev <Akhmad100913@gmail.com>
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> index bcaf63b28..6fc3774d2 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
> @@ -191,7 +191,7 @@ static s32 polling_fwdl_chksum(
>  		value32 = rtw_read32(adapter, REG_MCUFWDL);
>  		if (value32 & FWDL_ChkSum_rpt || adapter->bSurpriseRemoved || adapter->bDriverStopped)
>  			break;
> -		yield();
> +		cond_resched();

Are you sure this is correct?

thanks,

greg k-h

Re: [PATCH] staging: rtl8723bs: replace yield() with cond_resched()

[Greg KH]

On Tue, Jul 28, 2026 at 11:22:55AM +0300, Ахмад Зубайругаджиев wrote:
> Hi Greg,

Oops, again you top-posted and sent html email :(