* [PATCH] staging: axis-fifo: Fix alignment in open parentheses
@ 2026-07-23 16:31 Jeffin Philip
2026-07-28 7:08 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Jeffin Philip @ 2026-07-23 16:31 UTC (permalink / raw)
To: gregkh
Cc: ovidiu.panait.oss, error27, gustavopiazdasilva2102, linux-staging,
linux-kernel, Jeffin Philip
Fix checkpatch error:
"Alignment should match open parenthesis" in axis-fifo.c
Thanks,
Jeffin
Signed-off-by: Jeffin Philip <jeffinphilip14@gmail.com>
---
drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
index 3aa2aa870ea9..e8facc9b429b 100644
--- a/drivers/staging/axis-fifo/axis-fifo.c
+++ b/drivers/staging/axis-fifo/axis-fifo.c
@@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
mutex_lock(&fifo->write_lock);
ret = wait_event_interruptible(fifo->write_queue,
- ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
+ ioread32(fifo->base_addr +
+ XLLF_TDFV_OFFSET) >= words_to_write);
if (ret)
goto end_unlock;
}
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: axis-fifo: Fix alignment in open parentheses
2026-07-23 16:31 [PATCH] staging: axis-fifo: Fix alignment in open parentheses Jeffin Philip
@ 2026-07-28 7:08 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2026-07-28 7:08 UTC (permalink / raw)
To: Jeffin Philip
Cc: ovidiu.panait.oss, error27, gustavopiazdasilva2102, linux-staging,
linux-kernel
On Thu, Jul 23, 2026 at 10:01:10PM +0530, Jeffin Philip wrote:
> Fix checkpatch error:
> "Alignment should match open parenthesis" in axis-fifo.c
>
> Thanks,
> Jeffin
No need for this in the middle of a changelog text :)
>
> Signed-off-by: Jeffin Philip <jeffinphilip14@gmail.com>
> ---
> drivers/staging/axis-fifo/axis-fifo.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index 3aa2aa870ea9..e8facc9b429b 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -246,7 +246,8 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
> mutex_lock(&fifo->write_lock);
>
> ret = wait_event_interruptible(fifo->write_queue,
> - ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) >= words_to_write);
> + ioread32(fifo->base_addr +
> + XLLF_TDFV_OFFSET) >= words_to_write);
> if (ret)
> goto end_unlock;
> }
> --
> 2.55.0
>
This change:
https://lore.kernel.org/r/20260721030618.27784-1-amnashamraze1@gmail.com
does it a bit better, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-28 7:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-23 16:31 [PATCH] staging: axis-fifo: Fix alignment in open parentheses Jeffin Philip
2026-07-28 7:08 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox