* [PATCH] staging: vc04_services: preserve bcm2835_audio_write errors
@ 2026-08-03 4:09 Lucas Jeffrey
0 siblings, 0 replies; only message in thread
From: Lucas Jeffrey @ 2026-08-03 4:09 UTC (permalink / raw)
To: gregkh
Cc: florian.fainelli, rjui, sbranden, bcm-kernel-feedback-list,
linux-staging, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
Lucas Jeffrey
When sending audio data in multiple packets, a successful later packet
could overwrite an earlier failure in status. This caused the function
to report success even if one packet was not queued.
Stop sending packets after the first failure to preserve the error.
Signed-off-by: Lucas Jeffrey <luquijeffrey@gmail.com>
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
index 3156cb8392f4..5ac23cfa7983 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
+++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
@@ -365,6 +365,9 @@ int bcm2835_audio_write(struct bcm2835_alsa_stream *alsa_stream,
status = vchiq_queue_kernel_message(vchiq_instance,
instance->service_handle, src, bytes);
+ if (status)
+ break;
+
src += bytes;
count -= bytes;
}
--
2.43.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-08-03 4:09 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-03 4:09 [PATCH] staging: vc04_services: preserve bcm2835_audio_write errors Lucas Jeffrey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox