* [PATCH] staging: greybus: light: use sysfs_emit() instead of sprintf()
@ 2026-08-08 17:13 Mohit Mishra
0 siblings, 0 replies; only message in thread
From: Mohit Mishra @ 2026-08-08 17:13 UTC (permalink / raw)
To: Johan Hovold, Alex Elder, Greg Kroah-Hartman, Rui Miguel Silva
Cc: greybus-dev, linux-staging, linux-kernel, Mohit Mishra
color_show() and fade_show callbacks use sprintf() to format sysfs output
into the page buffer. Convert them to sysfs_emit(), which is the preferred
helper for sysfs show() callbacks as it enforces page boundary checks.
Similar conversions have already been made elsewhere in this subsystem
(e.g. loopback.c, arche-platform.c).
Signed-off-by: Mohit Mishra <mishraloopmohit@gmail.com>
---
drivers/staging/greybus/light.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
index cab02b5da867..2689f9a7524a 100644
--- a/drivers/staging/greybus/light.c
+++ b/drivers/staging/greybus/light.c
@@ -173,7 +173,7 @@ static ssize_t fade_##__dir##_show(struct device *dev, \
struct led_classdev *cdev = dev_get_drvdata(dev); \
struct gb_channel *channel = get_channel_from_cdev(cdev); \
\
- return sprintf(buf, "%u\n", channel->fade_##__dir); \
+ return sysfs_emit(buf, "%u\n", channel->fade_##__dir); \
} \
\
static ssize_t fade_##__dir##_store(struct device *dev, \
@@ -220,7 +220,7 @@ static ssize_t color_show(struct device *dev, struct device_attribute *attr,
struct led_classdev *cdev = dev_get_drvdata(dev);
struct gb_channel *channel = get_channel_from_cdev(cdev);
- return sprintf(buf, "0x%08x\n", channel->color);
+ return sysfs_emit(buf, "0x%08x\n", channel->color);
}
static ssize_t color_store(struct device *dev, struct device_attribute *attr,
--
2.43.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-08-08 17:13 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-08 17:13 [PATCH] staging: greybus: light: use sysfs_emit() instead of sprintf() Mohit Mishra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox