Re: [PATCH] staging: greybus: add missing newline to sysfs_emit() calls in audio_manager_module.c

Re: [PATCH] staging: greybus: add missing newline to sysfs_emit() calls in audio_manager_module.c

[Raushan Kumar]

Hi Dan,

Thanks for explaining — I'm new to kernel development and didn't
realize this sysfs output format was already user-visible API. I
understand now, and I'll leave this one as is.

Thanks for the feedback,
Raushan kumar

[PATCH] staging: greybus: add missing newline to sysfs_emit() calls in audio_manager_module.c

[Raushan Kumar]

sysfs attribute show functions are expected to terminate their
output with a newline. Add the missing \n to the format strings
in gb_audio_module_name_show(), gb_audio_module_vid_show(),
gb_audio_module_pid_show(), gb_audio_module_intf_id_show(),
gb_audio_module_ip_devices_show(), and
gb_audio_module_op_devices_show(), as flagged by checkpatch.pl.

Signed-off-by: Raushan Kumar <mitramaurya80@gmail.com>
---
 drivers/staging/greybus/audio_manager_module.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
index dc90cc2d2308..5737f2a32f5a 100644
--- a/drivers/staging/greybus/audio_manager_module.c
+++ b/drivers/staging/greybus/audio_manager_module.c
@@ -75,7 +75,7 @@ static void gb_audio_module_release(struct kobject *kobj)
 static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *module,
 					 struct gb_audio_manager_module_attribute *attr, char *buf)
 {
-	return sysfs_emit(buf, "%s", module->desc.name);
+	return sysfs_emit(buf, "%s\n", module->desc.name);
 }
 
 static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute =
@@ -84,7 +84,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute =
 static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *module,
 					struct gb_audio_manager_module_attribute *attr, char *buf)
 {
-	return sysfs_emit(buf, "%d", module->desc.vid);
+	return sysfs_emit(buf, "%d\n", module->desc.vid);
 }
 
 static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute =
@@ -93,7 +93,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute =
 static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *module,
 					struct gb_audio_manager_module_attribute *attr, char *buf)
 {
-	return sysfs_emit(buf, "%d", module->desc.pid);
+	return sysfs_emit(buf, "%d\n", module->desc.pid);
 }
 
 static struct gb_audio_manager_module_attribute gb_audio_module_pid_attribute =
@@ -103,7 +103,7 @@ static ssize_t gb_audio_module_intf_id_show(struct gb_audio_manager_module *modu
 					    struct gb_audio_manager_module_attribute *attr,
 					    char *buf)
 {
-	return sysfs_emit(buf, "%d", module->desc.intf_id);
+	return sysfs_emit(buf, "%d\n", module->desc.intf_id);
 }
 
 static struct gb_audio_manager_module_attribute
@@ -114,7 +114,7 @@ static ssize_t gb_audio_module_ip_devices_show(struct gb_audio_manager_module *m
 					       struct gb_audio_manager_module_attribute *attr,
 					       char *buf)
 {
-	return sysfs_emit(buf, "0x%X", module->desc.ip_devices);
+	return sysfs_emit(buf, "0x%X\n", module->desc.ip_devices);
 }
 
 static struct gb_audio_manager_module_attribute
@@ -125,7 +125,7 @@ static ssize_t gb_audio_module_op_devices_show(struct gb_audio_manager_module *m
 					       struct gb_audio_manager_module_attribute *attr,
 					       char *buf)
 {
-	return sysfs_emit(buf, "0x%X", module->desc.op_devices);
+	return sysfs_emit(buf, "0x%X\n", module->desc.op_devices);
 }
 
 static struct gb_audio_manager_module_attribute
-- 
2.55.0

Re: [PATCH] staging: greybus: add missing newline to sysfs_emit() calls in audio_manager_module.c

[Dan Carpenter]

On Wed, Aug 12, 2026 at 02:21:17PM +0530, Raushan Kumar wrote:
> sysfs attribute show functions are expected to terminate their
> output with a newline. Add the missing \n to the format strings
> in gb_audio_module_name_show(), gb_audio_module_vid_show(),
> gb_audio_module_pid_show(), gb_audio_module_intf_id_show(),
> gb_audio_module_ip_devices_show(), and
> gb_audio_module_op_devices_show(), as flagged by checkpatch.pl.
> 
> Signed-off-by: Raushan Kumar <mitramaurya80@gmail.com>
> ---

No, this is user visible API.  It's too risky to change once it's been
released.

regards,
dan carpenter