* [PATCH] staging: rtl8723bs: modify misleading comment
@ 2026-08-21 19:58 Omer El Idrissi
2026-08-21 20:53 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Omer El Idrissi @ 2026-08-21 19:58 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Omer El Idrissi
The comment suggests that rtw_unregister_cmd_alive is called
by the ISR, while it's called by function rtw_cmd_thread which runs in
the kernel thread context.
Signed-off-by: Omer El Idrissi <omer.e.idrissi@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
index b9f8cf1014ed..a4831dc145eb 100644
--- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
@@ -891,7 +891,7 @@ void rtw_unregister_tx_alive(struct adapter *padapter)
}
/*
- * Caller: ISR
+ * Caller: not ISR
*
* If all commands have been done,
* and no more command to do,
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: modify misleading comment
2026-08-21 19:58 [PATCH] staging: rtl8723bs: modify misleading comment Omer El Idrissi
@ 2026-08-21 20:53 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2026-08-21 20:53 UTC (permalink / raw)
To: Omer El Idrissi; +Cc: gregkh, linux-staging, linux-kernel
On Fri, Aug 21, 2026 at 09:58:23PM +0200, Omer El Idrissi wrote:
> The comment suggests that rtw_unregister_cmd_alive is called
> by the ISR, while it's called by function rtw_cmd_thread which runs in
> the kernel thread context.
>
> Signed-off-by: Omer El Idrissi <omer.e.idrissi@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> index b9f8cf1014ed..a4831dc145eb 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> @@ -891,7 +891,7 @@ void rtw_unregister_tx_alive(struct adapter *padapter)
> }
>
> /*
> - * Caller: ISR
> + * Caller: not ISR
The original comment is obviously wrong, and that's bad. But is "not ISR"
useful? Probably we might as well just delete the comment. It's not
like people don't have ctags.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-21 20:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-21 19:58 [PATCH] staging: rtl8723bs: modify misleading comment Omer El Idrissi
2026-08-21 20:53 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox