[PATCH v2] staging: media: atomisp: remove unnecessary void function return

[PATCH v2] staging: media: atomisp: remove unnecessary void function return

[Matthew Zvolsky]

Remove an unneeded return statement at the end of a void function
in atomisp_cmd.c. This cleans up the code and fixes a checkpatch.pl
warning: "void function return statements are not generally useful".

Signed-off-by: Matthew Zvolsky <matthew-kernel@post.cz>
---
 drivers/staging/media/atomisp/pci/atomisp_cmd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index 6cd500d9fd26..81d0afae8041 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -1419,7 +1419,6 @@ static void atomisp_update_grid_info(struct atomisp_sub_device *asd,
 
 err:
 	atomisp_css_free_stat_buffers(asd);
-	return;
 }
 
 static void atomisp_curr_user_grid_info(struct atomisp_sub_device *asd,
-- 
2.39.5

Re: [PATCH v2] staging: media: atomisp: remove unnecessary void function return

[Greg KH]

On Mon, Aug 24, 2026 at 03:45:25PM +0200, Matthew Zvolsky wrote:
> Remove an unneeded return statement at the end of a void function
> in atomisp_cmd.c. This cleans up the code and fixes a checkpatch.pl
> warning: "void function return statements are not generally useful".
> 
> Signed-off-by: Matthew Zvolsky <matthew-kernel@post.cz>
> ---
>  drivers/staging/media/atomisp/pci/atomisp_cmd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> index 6cd500d9fd26..81d0afae8041 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> @@ -1419,7 +1419,6 @@ static void atomisp_update_grid_info(struct atomisp_sub_device *asd,
>  
>  err:
>  	atomisp_css_free_stat_buffers(asd);
> -	return;
>  }
>  
>  static void atomisp_curr_user_grid_info(struct atomisp_sub_device *asd,
> -- 
> 2.39.5
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot