[PATCH] staging: rtl8723bs: fix coding style issues in xmit_linux.c

[PATCH] staging: rtl8723bs: fix coding style issues in xmit_linux.c

[Godana Emiru]

Fix a handful of coding style issues in xmit_linux.c:

- Remove a stray extra blank line after the include.
- Split two chained assignments in _rtw_open_pktfile() into
  separate statements, one variable per line.
- Wrap the long rtw_os_xmit_resource_free() prototype so it fits
  within the column limit, aligned to the open parenthesis.

No functional change.

Signed-off-by: Godana Emiru <godanaemiru@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
index 4260ed5f4..4a3c3df5a 100644
--- a/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/xmit_linux.c
@@ -6,7 +6,6 @@
  ******************************************************************************/
 #include <drv_types.h>
 
-
 uint rtw_remainder_len(struct pkt_file *pfile)
 {
 	return (pfile->buf_len - ((SIZE_PTR)(pfile->cur_addr) - (SIZE_PTR)(pfile->buf_start)));
@@ -15,8 +14,10 @@ uint rtw_remainder_len(struct pkt_file *pfile)
 void _rtw_open_pktfile(struct sk_buff *pktptr, struct pkt_file *pfile)
 {
 	pfile->pkt = pktptr;
-	pfile->cur_addr = pfile->buf_start = pktptr->data;
-	pfile->pkt_len = pfile->buf_len = pktptr->len;
+	pfile->buf_start = pktptr->data;
+	pfile->cur_addr = pfile->buf_start;
+	pfile->buf_len = pktptr->len;
+	pfile->pkt_len = pfile->buf_len;
 
 	pfile->cur_buffer = pfile->buf_start;
 }
@@ -48,7 +49,8 @@ signed int rtw_endofpktfile(struct pkt_file *pfile)
 	return false;
 }
 
-void rtw_os_xmit_resource_free(struct adapter *padapter, struct xmit_buf *pxmitbuf, u32 free_sz, u8 flag)
+void rtw_os_xmit_resource_free(struct adapter *padapter, struct xmit_buf *pxmitbuf,
+			       u32 free_sz, u8 flag)
 {
 	if (free_sz > 0)
 		kfree(pxmitbuf->pallocated_buf);
-- 
2.53.0

Re: [PATCH] staging: rtl8723bs: fix coding style issues in xmit_linux.c

[Greg KH]

On Wed, Aug 26, 2026 at 10:40:59PM +0300, Godana Emiru wrote:
> Fix a handful of coding style issues in xmit_linux.c:
> 
> - Remove a stray extra blank line after the include.
> - Split two chained assignments in _rtw_open_pktfile() into
>   separate statements, one variable per line.
> - Wrap the long rtw_os_xmit_resource_free() prototype so it fits
>   within the column limit, aligned to the open parenthesis.

These are different things, so this should be a patch series, each doing
only one logical thing.

thanks,

greg k-h