From: Greg KH <gregkh@linuxfoundation.org>
To: Noah Techoueyres <noahtechoueyres@gmail.com>
Cc: pure.logic@nexus-software.ie, johan@kernel.org, elder@kernel.org,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: greybus: loopback: Fix argument alignment
Date: Tue, 1 Sep 2026 11:40:15 +0200 [thread overview]
Message-ID: <2026090156-effective-anybody-a347@gregkh> (raw)
In-Reply-To: <20260803015022.534-1-noahtechoueyres@gmail.com>
On Sun, Aug 02, 2026 at 09:50:22PM -0400, Noah Techoueyres wrote:
> Align function arguments to match the open parenthesis
> per the kernel coding style guidelines.
>
> Signed-off-by: Noah Techoueyres <noahtechoueyres@gmail.com>
> ---
> drivers/staging/greybus/loopback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> index ea57b1f5d156..c33b8aa5871c 100644
> --- a/drivers/staging/greybus/loopback.c
> +++ b/drivers/staging/greybus/loopback.c
> @@ -679,7 +679,7 @@ static int gb_loopback_request_handler(struct gb_operation *operation)
> }
>
> if (!gb_operation_response_alloc(operation,
> - len + sizeof(*response), GFP_KERNEL)) {
> + len + sizeof(*response), GFP_KERNEL)) {
Now you are over 80 columns, this keeps going back and forth. It's fine
as-is.
thanks,
greg k-h
prev parent reply other threads:[~2026-09-01 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 1:50 [PATCH] staging: greybus: loopback: Fix argument alignment Noah Techoueyres
2026-09-01 9:40 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026090156-effective-anybody-a347@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=elder@kernel.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=noahtechoueyres@gmail.com \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox