* [PATCH] staging: greybus: loopback: Fix argument alignment
@ 2026-08-03 1:50 Noah Techoueyres
2026-09-01 9:40 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Noah Techoueyres @ 2026-08-03 1:50 UTC (permalink / raw)
To: pure.logic, johan, elder, gregkh
Cc: greybus-dev, linux-staging, Noah Techoueyres
Align function arguments to match the open parenthesis
per the kernel coding style guidelines.
Signed-off-by: Noah Techoueyres <noahtechoueyres@gmail.com>
---
drivers/staging/greybus/loopback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index ea57b1f5d156..c33b8aa5871c 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -679,7 +679,7 @@ static int gb_loopback_request_handler(struct gb_operation *operation)
}
if (!gb_operation_response_alloc(operation,
- len + sizeof(*response), GFP_KERNEL)) {
+ len + sizeof(*response), GFP_KERNEL)) {
dev_err(dev, "error allocating response\n");
return -ENOMEM;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: greybus: loopback: Fix argument alignment
2026-08-03 1:50 [PATCH] staging: greybus: loopback: Fix argument alignment Noah Techoueyres
@ 2026-09-01 9:40 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2026-09-01 9:40 UTC (permalink / raw)
To: Noah Techoueyres; +Cc: pure.logic, johan, elder, greybus-dev, linux-staging
On Sun, Aug 02, 2026 at 09:50:22PM -0400, Noah Techoueyres wrote:
> Align function arguments to match the open parenthesis
> per the kernel coding style guidelines.
>
> Signed-off-by: Noah Techoueyres <noahtechoueyres@gmail.com>
> ---
> drivers/staging/greybus/loopback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> index ea57b1f5d156..c33b8aa5871c 100644
> --- a/drivers/staging/greybus/loopback.c
> +++ b/drivers/staging/greybus/loopback.c
> @@ -679,7 +679,7 @@ static int gb_loopback_request_handler(struct gb_operation *operation)
> }
>
> if (!gb_operation_response_alloc(operation,
> - len + sizeof(*response), GFP_KERNEL)) {
> + len + sizeof(*response), GFP_KERNEL)) {
Now you are over 80 columns, this keeps going back and forth. It's fine
as-is.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-01 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-03 1:50 [PATCH] staging: greybus: loopback: Fix argument alignment Noah Techoueyres
2026-09-01 9:40 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox