[PATCH] staging: greybus: camera: Fix function declaration alignment

[PATCH] staging: greybus: camera: Fix function declaration alignment

[S Tarun Kumar Lywait]

Adhere to Linux kernel coding style. Reported by checkpatch:
CHECK: Alignment should match open parenthesis

Signed-off-by: S Tarun Kumar Lywait <tarun.k.lywait@gmail.com>
---
 drivers/staging/greybus/camera.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
index 62b55bb28408..9853bd60ff27 100644
--- a/drivers/staging/greybus/camera.c
+++ b/drivers/staging/greybus/camera.c
@@ -263,9 +263,10 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
  * Validate the stream configuration response verifying padding is correctly
  * set and the returned number of streams is supported
  */
-static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam,
-		struct gb_camera_configure_streams_response *resp,
-		unsigned int nstreams)
+static const int gb_camera_configure_streams_validate_response
+	(struct gb_camera *gcam,
+	 struct gb_camera_configure_streams_response *resp,
+	 unsigned int nstreams)
 {
 	unsigned int i;
 
-- 
2.47.3

Re: [PATCH] staging: greybus: camera: Fix function declaration alignment

[Greg KH]

On Tue, Sep 08, 2026 at 10:40:11PM +0530, S Tarun Kumar Lywait wrote:
> Adhere to Linux kernel coding style. Reported by checkpatch:
> CHECK: Alignment should match open parenthesis
> 
> Signed-off-by: S Tarun Kumar Lywait <tarun.k.lywait@gmail.com>
> ---
>  drivers/staging/greybus/camera.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
> index 62b55bb28408..9853bd60ff27 100644
> --- a/drivers/staging/greybus/camera.c
> +++ b/drivers/staging/greybus/camera.c
> @@ -263,9 +263,10 @@ static int gb_camera_get_max_pkt_size(struct gb_camera *gcam,
>   * Validate the stream configuration response verifying padding is correctly
>   * set and the returned number of streams is supported
>   */
> -static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam,
> -		struct gb_camera_configure_streams_response *resp,
> -		unsigned int nstreams)
> +static const int gb_camera_configure_streams_validate_response
> +	(struct gb_camera *gcam,

That does not look correct at all, what tool asked you to make this type
of change?

thanks,

greg k-h

Re: [PATCH] staging: greybus: camera: Fix function declaration alignment

[S Tarun Kumar Lywait]

> That does not look correct at all, what tool asked you to make this type
> of change?

I used the checkpatch script itself (./scripts/checkpatch.pl). At first, it showed me the following issue:

CHECK: Alignment should match open parenthesis
#267: FILE: drivers/staging/greybus/camera.c:267:
+static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam,
+               struct gb_camera_configure_streams_response *resp,

So I fixed the alignment as follows:

static const int gb_camera_configure_streams_validate_response(struct gb_camera *gcam,
                                                               struct gb_camera_configure_streams_response *resp,
                                                               unsigned int nstreams)

But after making this change, I ran the script again and found another issue popping up, replacing the earlier issue:

CHECK: line length of 113 exceeds 100 columns
#267: FILE: drivers/staging/greybus/camera.c:267:
+                                                             struct gb_camera_configure_streams_response *resp,

So, I finally ended up with the current patch, that didn't raise any issue pertaining to this, when running the checkpatch script.

Please let me know in case of further queries.

Thanks,
Tarun Lywait