[PATCH] staging: rtl8723bs: remove unnecessary NULL check before kfree

[PATCH] staging: rtl8723bs: remove unnecessary NULL check before kfree

[Callan McClish]

kfree(NULL) is a safe operation and an explicit NULL check is redundant,
therefore it should be omitted.
Detected by checkpatch.

Signed-off-by: Callan McClish <mcclishcallan@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 81d9e713fc12..6aaa07813d46 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -1748,10 +1748,9 @@ s32 rtw_free_xmitframe(struct xmit_priv *pxmitpriv, struct xmit_frame *pxmitfram
 		pxmitframe->pkt = NULL;
 	}
 
-	if (pxmitframe->alloc_addr) {
-		kfree(pxmitframe->alloc_addr);
+	kfree(pxmitframe->alloc_addr);
+	if (pxmitframe->alloc_addr)
 		goto check_pkt_complete;
-	}
 
 	if (pxmitframe->ext_tag == 0)
 		queue = &pxmitpriv->free_xmit_queue;
-- 
2.55.0

Re: [PATCH] staging: rtl8723bs: remove unnecessary NULL check before kfree

[Dan Carpenter]

On Sun, Sep 20, 2026 at 04:30:40PM -0700, Callan McClish wrote:
> kfree(NULL) is a safe operation and an explicit NULL check is redundant,
> therefore it should be omitted.
> Detected by checkpatch.
> 
> Signed-off-by: Callan McClish <mcclishcallan@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> index 81d9e713fc12..6aaa07813d46 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> @@ -1748,10 +1748,9 @@ s32 rtw_free_xmitframe(struct xmit_priv *pxmitpriv, struct xmit_frame *pxmitfram
>  		pxmitframe->pkt = NULL;
>  	}
>  
> -	if (pxmitframe->alloc_addr) {
> -		kfree(pxmitframe->alloc_addr);
> +	kfree(pxmitframe->alloc_addr);
> +	if (pxmitframe->alloc_addr)
>  		goto check_pkt_complete;
> -	}

Do a search on lore before sending patches...  We need to add some
new drivers to staging because people seem to be doing the same
things over and over...

https://lore.kernel.org/all/ajT23QSZDVNdD8M_@stanley.mountain/

I guess this still works as a lesson in ignoring checkpatch and
being skeptical of advice from tools...

regards,
dan carpenter