linux-staging.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Muhammad Mahdi Amirpour <ampr.mhd@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: use u8 instead of unsigned char in NDIS typedefs
Date: Tue, 13 Oct 2026 15:33:23 +0200	[thread overview]
Message-ID: <2026101314-dimmer-squishier-3781@gregkh> (raw)
In-Reply-To: <20261007103236.37607-1-ampr.mhd@gmail.com>

On Wed, Oct 07, 2026 at 02:02:36PM +0330, Muhammad Mahdi Amirpour wrote:
> Replace the plain C type 'unsigned char' with the kernel's fixed-width
> type 'u8' in the NDIS_802_11_RATES and NDIS_802_11_RATES_EX typedefs.
> 
> The kernel coding style prefers fixed-width types over plain C types.
> This addresses one of the outstanding TODO items in the rtl8723bs
> driver: "convert any remaining unusual variable types".
> 
> No functional change.
> 
> Signed-off-by: Muhammad Mahdi Amirpour <ampr.mhd@gmail.com>
> ---
>  drivers/staging/rtl8723bs/include/wlan_bssdef.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/wlan_bssdef.h b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> index f4c1456f1..df541e956 100644
> --- a/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> +++ b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> @@ -15,8 +15,8 @@
>  #define NDIS_802_11_LENGTH_RATES        8
>  #define NDIS_802_11_LENGTH_RATES_EX     16
>  
> -typedef unsigned char   NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];        /*  Set of 8 data rates */
> -typedef unsigned char   NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];  /*  Set of 16 data rates */
> +typedef u8 NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES];        /*  Set of 8 data rates */
> +typedef u8 NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX];  /*  Set of 16 data rates */
>  
>  struct ndis_802_11_ssid {
>  	u32 ssid_length;
> -- 
> 2.55.0
> 

Does not apply to the the staging-next branch at all :(

      reply	other threads:[~2026-10-13 13:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07 10:32 [PATCH v2] staging: rtl8723bs: use u8 instead of unsigned char in NDIS typedefs Muhammad Mahdi Amirpour
2026-10-13 13:33 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026101314-dimmer-squishier-3781@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ampr.mhd@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).