* [PATCH v2] staging: rtl8723bs: use u8 instead of unsigned char in NDIS typedefs
@ 2026-10-07 10:32 Muhammad Mahdi Amirpour
2026-10-13 13:33 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Muhammad Mahdi Amirpour @ 2026-10-07 10:32 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Muhammad Mahdi Amirpour
Replace the plain C type 'unsigned char' with the kernel's fixed-width
type 'u8' in the NDIS_802_11_RATES and NDIS_802_11_RATES_EX typedefs.
The kernel coding style prefers fixed-width types over plain C types.
This addresses one of the outstanding TODO items in the rtl8723bs
driver: "convert any remaining unusual variable types".
No functional change.
Signed-off-by: Muhammad Mahdi Amirpour <ampr.mhd@gmail.com>
---
drivers/staging/rtl8723bs/include/wlan_bssdef.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/wlan_bssdef.h b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
index f4c1456f1..df541e956 100644
--- a/drivers/staging/rtl8723bs/include/wlan_bssdef.h
+++ b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
@@ -15,8 +15,8 @@
#define NDIS_802_11_LENGTH_RATES 8
#define NDIS_802_11_LENGTH_RATES_EX 16
-typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES]; /* Set of 8 data rates */
-typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX]; /* Set of 16 data rates */
+typedef u8 NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES]; /* Set of 8 data rates */
+typedef u8 NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX]; /* Set of 16 data rates */
struct ndis_802_11_ssid {
u32 ssid_length;
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: use u8 instead of unsigned char in NDIS typedefs
2026-10-07 10:32 [PATCH v2] staging: rtl8723bs: use u8 instead of unsigned char in NDIS typedefs Muhammad Mahdi Amirpour
@ 2026-10-13 13:33 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2026-10-13 13:33 UTC (permalink / raw)
To: Muhammad Mahdi Amirpour; +Cc: linux-staging, linux-kernel
On Wed, Oct 07, 2026 at 02:02:36PM +0330, Muhammad Mahdi Amirpour wrote:
> Replace the plain C type 'unsigned char' with the kernel's fixed-width
> type 'u8' in the NDIS_802_11_RATES and NDIS_802_11_RATES_EX typedefs.
>
> The kernel coding style prefers fixed-width types over plain C types.
> This addresses one of the outstanding TODO items in the rtl8723bs
> driver: "convert any remaining unusual variable types".
>
> No functional change.
>
> Signed-off-by: Muhammad Mahdi Amirpour <ampr.mhd@gmail.com>
> ---
> drivers/staging/rtl8723bs/include/wlan_bssdef.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/wlan_bssdef.h b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> index f4c1456f1..df541e956 100644
> --- a/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> +++ b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> @@ -15,8 +15,8 @@
> #define NDIS_802_11_LENGTH_RATES 8
> #define NDIS_802_11_LENGTH_RATES_EX 16
>
> -typedef unsigned char NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES]; /* Set of 8 data rates */
> -typedef unsigned char NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX]; /* Set of 16 data rates */
> +typedef u8 NDIS_802_11_RATES[NDIS_802_11_LENGTH_RATES]; /* Set of 8 data rates */
> +typedef u8 NDIS_802_11_RATES_EX[NDIS_802_11_LENGTH_RATES_EX]; /* Set of 16 data rates */
>
> struct ndis_802_11_ssid {
> u32 ssid_length;
> --
> 2.55.0
>
Does not apply to the the staging-next branch at all :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-13 13:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-07 10:32 [PATCH v2] staging: rtl8723bs: use u8 instead of unsigned char in NDIS typedefs Muhammad Mahdi Amirpour
2026-10-13 13:33 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox