From: Greg KH <gregkh@linuxfoundation.org>
To: Xia Yan <yana06070@163.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: remove unused CRTC cursor fields
Date: Thu, 15 Oct 2026 10:40:39 +0200 [thread overview]
Message-ID: <2026101530-upstage-schnapps-5503@gregkh> (raw)
In-Reply-To: <20261015082757.10371-1-yana06070@163.com>
On Thu, Oct 15, 2026 at 04:27:57PM +0800, Xia Yan wrote:
> The v_cursor and o_cursor members of struct lynxfb_crtc are never read
> or written. The cursor setup and update paths use cursor.vstart and
> cursor.offset in the embedded struct lynx_cursor instead.
>
> Remove the unused members to avoid keeping a second, unused set of
> cursor location fields. No functional change is intended.
>
> Assisted-by: LLM
> Signed-off-by: Xia Yan <yana06070@163.com>
> ---
>
> Notes (validation):
> Compile-tested on x86_64 with GCC 12.3.1 and CONFIG_FB_SM750=m, using W=1.
> All driver objects and the combined sm750fb.o built successfully.
Please read:
https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh
prev parent reply other threads:[~2026-10-15 8:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 8:27 [PATCH] staging: sm750fb: remove unused CRTC cursor fields Xia Yan
2026-10-15 8:40 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026101530-upstage-schnapps-5503@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
--cc=yana06070@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox