[PATCH] staging: sm750fb: remove unused CRTC cursor fields

[PATCH] staging: sm750fb: remove unused CRTC cursor fields

[Xia Yan]

The v_cursor and o_cursor members of struct lynxfb_crtc are never read
or written. The cursor setup and update paths use cursor.vstart and
cursor.offset in the embedded struct lynx_cursor instead.

Remove the unused members to avoid keeping a second, unused set of
cursor location fields. No functional change is intended.

Assisted-by: LLM
Signed-off-by: Xia Yan <yana06070@163.com>
---

Notes (validation):
    Compile-tested on x86_64 with GCC 12.3.1 and CONFIG_FB_SM750=m, using W=1.
    All driver objects and the combined sm750fb.o built successfully.

 drivers/staging/sm750fb/sm750.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index fd1cf9e..6e427d1 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -123,9 +123,7 @@ struct lynx_cursor {
 };
 
 struct lynxfb_crtc {
-	unsigned char __iomem *v_cursor; /* virtual address of cursor */
 	unsigned char __iomem *v_screen; /* virtual address of on_screen */
-	int o_cursor; /* cursor address offset in vidmem */
 	int o_screen; /* onscreen address offset in vidmem */
 	int channel;/* which channel this crtc stands for*/
 	resource_size_t vidmem_size;/* this view's video memory max size */

base-commit: cccafd0f36d8c30d4dcbdce26971dab15e8ab25b
-- 
2.33.0

Re: [PATCH] staging: sm750fb: remove unused CRTC cursor fields

[Greg KH]

On Thu, Oct 15, 2026 at 04:27:57PM +0800, Xia Yan wrote:
> The v_cursor and o_cursor members of struct lynxfb_crtc are never read
> or written. The cursor setup and update paths use cursor.vstart and
> cursor.offset in the embedded struct lynx_cursor instead.
> 
> Remove the unused members to avoid keeping a second, unused set of
> cursor location fields. No functional change is intended.
> 
> Assisted-by: LLM
> Signed-off-by: Xia Yan <yana06070@163.com>
> ---
> 
> Notes (validation):
>     Compile-tested on x86_64 with GCC 12.3.1 and CONFIG_FB_SM750=m, using W=1.
>     All driver objects and the combined sm750fb.o built successfully.

Please read:
	https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh