* Re: [PATCH] staging: fbtft: Fix continuation line alignment
2026-10-18 12:34 [PATCH] staging: fbtft: Fix continuation line alignment Bashirah Lawal
@ 2026-10-18 13:31 ` Greg KH
2026-10-18 13:38 ` Dan Carpenter
2026-10-19 0:29 ` Julia Lawall
2 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2026-10-18 13:31 UTC (permalink / raw)
To: Bashirah Lawal; +Cc: andy, dri-devel, linux-fbdev, linux-staging, outreachy
On Sun, Oct 18, 2026 at 08:34:30AM -0400, Bashirah Lawal wrote:
> Signed-off-by: Bashirah Lawal <bashirahlawal017@gmail.com>
> ---
> drivers/staging/fbtft/fb_tinylcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
> index afa8f1c740c5..d58b1247262b 100644
> --- a/drivers/staging/fbtft/fb_tinylcd.c
> +++ b/drivers/staging/fbtft/fb_tinylcd.c
> @@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
> write_reg(par, 0xE5, 0x00);
> write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
> write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
> - 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> + 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- You did not specify a description of why the patch is needed, or
possibly, any description at all, in the email body. Please read the
section entitled "The canonical patch format" in the kernel file,
Documentation/process/submitting-patches.rst for what is needed in
order to properly describe the change.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: fbtft: Fix continuation line alignment
2026-10-18 12:34 [PATCH] staging: fbtft: Fix continuation line alignment Bashirah Lawal
2026-10-18 13:31 ` Greg KH
@ 2026-10-18 13:38 ` Dan Carpenter
2026-10-19 0:29 ` Julia Lawall
2 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2026-10-18 13:38 UTC (permalink / raw)
To: Bashirah Lawal
Cc: andy, gregkh, dri-devel, linux-fbdev, linux-staging, outreachy
On Sun, Oct 18, 2026 at 08:34:30AM -0400, Bashirah Lawal wrote:
> Signed-off-by: Bashirah Lawal <bashirahlawal017@gmail.com>
> ---
> drivers/staging/fbtft/fb_tinylcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
> index afa8f1c740c5..d58b1247262b 100644
> --- a/drivers/staging/fbtft/fb_tinylcd.c
> +++ b/drivers/staging/fbtft/fb_tinylcd.c
> @@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
> write_reg(par, 0xE5, 0x00);
> write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
> write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
> - 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> + 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
The original was better. Search lore for the function name to see ealier
discussions on this subject.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] staging: fbtft: Fix continuation line alignment
2026-10-18 12:34 [PATCH] staging: fbtft: Fix continuation line alignment Bashirah Lawal
2026-10-18 13:31 ` Greg KH
2026-10-18 13:38 ` Dan Carpenter
@ 2026-10-19 0:29 ` Julia Lawall
2 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2026-10-19 0:29 UTC (permalink / raw)
To: Bashirah Lawal
Cc: andy, gregkh, dri-devel, linux-fbdev, linux-staging, outreachy
On Sun, 18 Oct 2026, Bashirah Lawal wrote:
Hello Bashirah,
As noted by Greg's automatic message, you can't rely on the subject line
to explain everything. Every patch must have a comment saying what you
have done and why.
julia
> Signed-off-by: Bashirah Lawal <bashirahlawal017@gmail.com>
> ---
> drivers/staging/fbtft/fb_tinylcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
> index afa8f1c740c5..d58b1247262b 100644
> --- a/drivers/staging/fbtft/fb_tinylcd.c
> +++ b/drivers/staging/fbtft/fb_tinylcd.c
> @@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
> write_reg(par, 0xE5, 0x00);
> write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
> write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
> - 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> + 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55);
> write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE);
> fsleep(250);
> --
> 2.53.0
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread