From: Joshua Crofts <crofts@kernel.org>
To: Nick <nick21042013@gmail.com>
Cc: gregkh@linuxfoundation.org, jic23@kernel.org, lars@metafoo.de,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re:
Date: Tue, 10 Nov 2026 15:17:51 +0100 [thread overview]
Message-ID: <20261110151751.0000582f@kernel.org> (raw)
In-Reply-To: <20261110140354.2047-1-nick21042013@gmail.com>
Hi Nick,
Several issues with this patch unfortunately :(
On Tue, 10 Nov 2026 20:33:54 +0630
Nick <nick21042013@gmail.com> wrote:
> From: Nick <nick21042013@gmail.com>
>
> Date: Tue, 10 Nov 2026 19:57:26 +0630
>
> Subject: [PATCH] staging: iio: adt7316: fix camelCase violations
This shouldn't be in the body of the commit. Additionally, you're missing a
subject.
>
>
> Rename Vref and AIN to lowercase characters.
>
What's going on with the spacing? This unfortunately fails to apply, as
the patch is malformed. I see that you sent it with git send-email, but
was the patch created correctly with git format-patch?
> This fixes the style violations and brings
>
> the driver into line with the kernel style
>
> guidelines.
>
Additionally, the camelCase is intentional, as this is standard
notation for things like voltages.
>
> Signed-off-by: Nick <nick21042013@gmail.com>
Also, we need a full name in the Signed-off-by tag.
--
Kind regards,
Joshua Crofts
next prev parent reply other threads:[~2026-11-10 14:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 14:03 Nick
2026-11-10 14:17 ` Joshua Crofts [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-08-21 20:56 Kaden Vaughn
2026-08-21 21:01 ` Dan Carpenter
2024-01-16 6:46 meir elisha
2024-01-16 7:05 ` Dan Carpenter
2022-01-24 12:43 Arınç ÜNAL
2022-01-25 14:03 ` Sergio Paracuellos
2022-01-25 15:24 ` Re: Arınç ÜNAL
2022-01-25 15:50 ` Re: Sergio Paracuellos
2021-04-05 21:12 David Villasana Jiménez
2021-04-06 5:17 ` Greg KH
2021-04-05 0:01 Mitali Borkar
2021-04-06 7:03 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110151751.0000582f@kernel.org \
--to=crofts@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nick21042013@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox