Re:

Re:

[Greg KH]

On Mon, Apr 05, 2021 at 04:12:48PM -0500, David Villasana Jiménez wrote:
> linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
> Bcc: 
> Subject: [PATCH] staging: media: atomisp: i2c: Fix alignment to match open
>  parenthesis
> Reply-To: 

Something went wrong with your email again :(

Re:

[Arnd Bergmann]

On Mon, Apr 5, 2021 at 2:03 AM Mitali Borkar <mitaliborkar810@gmail.com> wrote:
>
> outreachy-kernel@googlegroups.com, mitaliborkar810@gmail.com
> Bcc:
> Subject: [PATCH] staging: qlge:remove else after break
> Reply-To:
>
> Fixed Warning:- else is not needed after break
> break terminates the loop if encountered. else is unnecessary and
> increases indenatation
>
> Signed-off-by: Mitali Borkar <mitaliborkar810@gmail.com>
> ---
>  drivers/staging/qlge/qlge_mpi.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge/qlge_mpi.c
> index 2630ebf50341..3a49f187203b 100644
> --- a/drivers/staging/qlge/qlge_mpi.c
> +++ b/drivers/staging/qlge/qlge_mpi.c
> @@ -935,13 +935,11 @@ static int qlge_idc_wait(struct qlge_adapter *qdev)
>                         netif_err(qdev, drv, qdev->ndev, "IDC Success.\n");
>                         status = 0;
>                         break;
> -               } else {
> -                       netif_err(qdev, drv, qdev->ndev,
> +               }       netif_err(qdev, drv, qdev->ndev,
>                                   "IDC: Invalid State 0x%.04x.\n",
>                                   mbcp->mbox_out[0]);
>                         status = -EIO;
>                         break;
> -               }
>         }

It looks like you got this one wrong in multiple ways:

- This is not an equivalent transformation, since the errror is now
  printed in the first part of the 'if()' block as well.

- The indentation is wrong now, with the netif_err() starting in the
  same line as the '}'.

- The description mentions a change in indentation, but you did not
   actually change it.

- The changelog text appears mangled.

        Arnd

Re:

[Sergio Paracuellos]

Hi Arinc!

On Mon, Jan 24, 2022 at 1:45 PM Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
>
> Hey everyone,
>
> In preperation to mainline mt7621-dts; fix formatting, dtc warning on
> switch0@0 node and pinctrl properties for ethernet node on the mt7621.dtsi.
> Move the GB-PC2 specific external phy configuration on the main dtsi to
> GB-PC2's devicetree, gbpc2.dts.
>
> Now that pinctrl properties are properly defined on the ethernet node,
> GMAC1 will start working.
>
> Traffic flow on GMAC1 was tested on a mt7621a board with these modes:
> External phy <-> GMAC1
> PHY 0/4 <-> GMAC1
>
> Cheers.
> Arınç

Nitpick: next time try to put also a subject like "staging:
mt7621-dts: cleanups (or whatever)" in the cover letter of the series.

>
> [0]: https://lore.kernel.org/netdev/83a35aa3-6cb8-2bc4-2ff4-64278bbcd8c8@arinc9.com/T/
>
> Arınç ÜNAL (4):
>       staging: mt7621-dts: fix formatting
>       staging: mt7621-dts: fix switch0@0 warnings
>       staging: mt7621-dts: use trgmii on gmac0 and enable flow control on port@6
>       staging: mt7621-dts: fix pinctrl properties for ethernet
>
>  drivers/staging/mt7621-dts/gbpc2.dts   | 16 +++++++++++-----
>  drivers/staging/mt7621-dts/mt7621.dtsi | 32 ++++++++++++++++----------------
>  2 files changed, 27 insertions(+), 21 deletions(-)
>
>

Thanks for doing this!

Best regards,
    Sergio Paracuellos

Re:

[Arınç ÜNAL]

Hey Sergio,

On 25/01/2022 17:03, Sergio Paracuellos wrote:
> Hi Arinc!
> 
> On Mon, Jan 24, 2022 at 1:45 PM Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
>>
>> Hey everyone,
>>
>> In preperation to mainline mt7621-dts; fix formatting, dtc warning on
>> switch0@0 node and pinctrl properties for ethernet node on the mt7621.dtsi.
>> Move the GB-PC2 specific external phy configuration on the main dtsi to
>> GB-PC2's devicetree, gbpc2.dts.
>>
>> Now that pinctrl properties are properly defined on the ethernet node,
>> GMAC1 will start working.
>>
>> Traffic flow on GMAC1 was tested on a mt7621a board with these modes:
>> External phy <-> GMAC1
>> PHY 0/4 <-> GMAC1
>>
>> Cheers.
>> Arınç
> 
> Nitpick: next time try to put also a subject like "staging:
> mt7621-dts: cleanups (or whatever)" in the cover letter of the series.

I had already sent v2 with that. I'll send v3 with your input on the 
series, thanks!

> 
>>
>> [0]: https://lore.kernel.org/netdev/83a35aa3-6cb8-2bc4-2ff4-64278bbcd8c8@arinc9.com/T/
>>
>> Arınç ÜNAL (4):
>>        staging: mt7621-dts: fix formatting
>>        staging: mt7621-dts: fix switch0@0 warnings
>>        staging: mt7621-dts: use trgmii on gmac0 and enable flow control on port@6
>>        staging: mt7621-dts: fix pinctrl properties for ethernet
>>
>>   drivers/staging/mt7621-dts/gbpc2.dts   | 16 +++++++++++-----
>>   drivers/staging/mt7621-dts/mt7621.dtsi | 32 ++++++++++++++++----------------
>>   2 files changed, 27 insertions(+), 21 deletions(-)
>>
>>
> 
> Thanks for doing this!
> 
> Best regards,
>      Sergio Paracuellos

Re:

[Sergio Paracuellos]

On Tue, Jan 25, 2022 at 4:24 PM Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
>
> Hey Sergio,
>
> On 25/01/2022 17:03, Sergio Paracuellos wrote:
> > Hi Arinc!
> >
> > On Mon, Jan 24, 2022 at 1:45 PM Arınç ÜNAL <arinc.unal@arinc9.com> wrote:
> >>
> >> Hey everyone,
> >>
> >> In preperation to mainline mt7621-dts; fix formatting, dtc warning on
> >> switch0@0 node and pinctrl properties for ethernet node on the mt7621.dtsi.
> >> Move the GB-PC2 specific external phy configuration on the main dtsi to
> >> GB-PC2's devicetree, gbpc2.dts.
> >>
> >> Now that pinctrl properties are properly defined on the ethernet node,
> >> GMAC1 will start working.
> >>
> >> Traffic flow on GMAC1 was tested on a mt7621a board with these modes:
> >> External phy <-> GMAC1
> >> PHY 0/4 <-> GMAC1
> >>
> >> Cheers.
> >> Arınç
> >
> > Nitpick: next time try to put also a subject like "staging:
> > mt7621-dts: cleanups (or whatever)" in the cover letter of the series.
>
> I had already sent v2 with that. I'll send v3 with your input on the
> series, thanks!

True, sorry I missed that!

Thanks,
    Sergio Paracuellos
>
> >
> >>
> >> [0]: https://lore.kernel.org/netdev/83a35aa3-6cb8-2bc4-2ff4-64278bbcd8c8@arinc9.com/T/
> >>
> >> Arınç ÜNAL (4):
> >>        staging: mt7621-dts: fix formatting
> >>        staging: mt7621-dts: fix switch0@0 warnings
> >>        staging: mt7621-dts: use trgmii on gmac0 and enable flow control on port@6
> >>        staging: mt7621-dts: fix pinctrl properties for ethernet
> >>
> >>   drivers/staging/mt7621-dts/gbpc2.dts   | 16 +++++++++++-----
> >>   drivers/staging/mt7621-dts/mt7621.dtsi | 32 ++++++++++++++++----------------
> >>   2 files changed, 27 insertions(+), 21 deletions(-)
> >>
> >>
> >
> > Thanks for doing this!
> >
> > Best regards,
> >      Sergio Paracuellos

Re:

[Dan Carpenter]

You have to send an email to linux-staging+subscribe@lists.linux.dev

regards,
dan carpenter

Re:

[Dan Carpenter]

Something went badly wrong...  Try sending it to yourself first
and applying it to a clean tree with `cat raw_email.txt | git am`

One of the rules is that you're not supposed to resend a patch multiple
times on the same day.  Slow down a bit please.

regards,
dan carpenter

(no subject)

[Nick]

From: Nick <nick21042013@gmail.com>

Date: Tue, 10 Nov 2026 19:57:26 +0630

Subject: [PATCH] staging: iio: adt7316: fix camelCase violations



Rename Vref and AIN to lowercase characters.

This fixes the style violations and brings

the driver into line with the kernel style

guidelines.



Signed-off-by: Nick <nick21042013@gmail.com>

---

 drivers/staging/iio/addac/adt7316.c | 12 ++++++------

 1 file changed, 6 insertions(+), 6 deletions(-)



diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c

index 20f6052cc..a71502cf0 100644

--- a/drivers/staging/iio/addac/adt7316.c

+++ b/drivers/staging/iio/addac/adt7316.c

@@ -663,7 +663,7 @@ static IIO_DEVICE_ATTR(da_high_resolution, 0644,

 		adt7316_store_da_high_resolution,

 		0);

 

-static ssize_t adt7316_show_AIN_internal_Vref(struct device *dev,

+static ssize_t adt7316_show_ain_internal_vref(struct device *dev,

 					      struct device_attribute *attr,

 					      char *buf)

 {

@@ -677,7 +677,7 @@ static ssize_t adt7316_show_AIN_internal_Vref(struct device *dev,

 		!!(chip->config3 & ADT7516_AIN_IN_VREF));

 }

 

-static ssize_t adt7316_store_AIN_internal_Vref(struct device *dev,

+static ssize_t adt7316_store_ain_internal_vref(struct device *dev,

 					       struct device_attribute *attr,

 					       const char *buf,

 					       size_t len)

@@ -704,9 +704,9 @@ static ssize_t adt7316_store_AIN_internal_Vref(struct device *dev,

 	return len;

 }

 

-static IIO_DEVICE_ATTR(AIN_internal_Vref, 0644,

-		adt7316_show_AIN_internal_Vref,

-		adt7316_store_AIN_internal_Vref,

+static IIO_DEVICE_ATTR(ain_internal_vref, 0644,

+		adt7316_show_ain_internal_vref,

+		adt7316_store_ain_internal_vref,

 		0);

 

 static ssize_t adt7316_show_enable_prop_DACA(struct device *dev,

@@ -1684,7 +1684,7 @@ static struct attribute *adt7516_attributes[] = {

 	&iio_dev_attr_enable_smbus_timeout.dev_attr.attr,

 	&iio_dev_attr_powerdown.dev_attr.attr,

 	&iio_dev_attr_fast_ad_clock.dev_attr.attr,

-	&iio_dev_attr_AIN_internal_Vref.dev_attr.attr,

+	&iio_dev_attr_ain_internal_vref.dev_attr.attr,

 	&iio_dev_attr_da_high_resolution.dev_attr.attr,

 	&iio_dev_attr_enable_proportion_DACA.dev_attr.attr,

 	&iio_dev_attr_enable_proportion_DACB.dev_attr.attr,

-- 

2.52.0.windows.1

Re:

[Joshua Crofts]

Hi Nick,

Several issues with this patch unfortunately :(

On Tue, 10 Nov 2026 20:33:54 +0630
Nick <nick21042013@gmail.com> wrote:

> From: Nick <nick21042013@gmail.com>
> 
> Date: Tue, 10 Nov 2026 19:57:26 +0630
> 
> Subject: [PATCH] staging: iio: adt7316: fix camelCase violations

This shouldn't be in the body of the commit. Additionally, you're missing a
subject.
> 
> 
> Rename Vref and AIN to lowercase characters.
> 

What's going on with the spacing? This unfortunately fails to apply, as
the patch is malformed. I see that you sent it with git send-email, but
was the patch created correctly with git format-patch?

> This fixes the style violations and brings
> 
> the driver into line with the kernel style
> 
> guidelines.
> 

Additionally, the camelCase is intentional, as this is standard
notation for things like voltages.

> 
> Signed-off-by: Nick <nick21042013@gmail.com>

Also, we need a full name in the Signed-off-by tag.

-- 
Kind regards,
Joshua Crofts