* [PATCH] media: atomisp: Remove unused ISP state control functions
@ 2026-11-21 12:25 Avishek Chaulagain
0 siblings, 0 replies; only message in thread
From: Avishek Chaulagain @ 2026-11-21 12:25 UTC (permalink / raw)
To: Hans de Goede, Andy Shevchenko, Mauro Carvalho Chehab
Cc: Sakari Ailus, Greg Kroah-Hartman, linux-media, linux-staging,
linux-kernel, Abhishek Chaulagain
From: Abhishek Chaulagain <chaulagainavishek14@gmail.com>
isp_is_ready(), isp_is_sleeping(), isp_start() and isp_wake() are
defined in isp.c and declared in isp_public.h, but have no callers
anywhere in the tree. Remove the four unused functions along with
their prototypes.
isp_wake() was the only user of udelay() in this file, so drop the
now-unused linux/delay.h include as well.
Signed-off-by: Abhishek Chaulagain <chaulagainavishek14@gmail.com>
---
.../pci/hive_isp_css_common/host/isp.c | 32 -------------------
.../hive_isp_css_include/host/isp_public.h | 8 -----
2 files changed, 40 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/isp.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/isp.c
index 39cccbfa3..13ea6d2a5 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/isp.c
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/isp.c
@@ -4,8 +4,6 @@
* Copyright (c) 2010-2015, Intel Corporation.
*/
-#include <linux/delay.h>
-
#include <system_global.h>
#include "isp.h"
@@ -29,33 +27,3 @@ void cnd_isp_irq_enable(
}
return;
}
-
-/* ISP functions to control the ISP state from the host, even in crun. */
-
-/* Inspect readiness of an ISP indexed by ID */
-unsigned int isp_is_ready(isp_ID_t ID)
-{
- assert(ID < N_ISP_ID);
- return isp_ctrl_getbit(ID, ISP_SC_REG, ISP_IDLE_BIT);
-}
-
-/* Inspect sleeping of an ISP indexed by ID */
-unsigned int isp_is_sleeping(isp_ID_t ID)
-{
- assert(ID < N_ISP_ID);
- return isp_ctrl_getbit(ID, ISP_SC_REG, ISP_SLEEPING_BIT);
-}
-
-/* To be called by the host immediately before starting ISP ID. */
-void isp_start(isp_ID_t ID)
-{
- assert(ID < N_ISP_ID);
-}
-
-/* Wake up ISP ID. */
-void isp_wake(isp_ID_t ID)
-{
- assert(ID < N_ISP_ID);
- isp_ctrl_setbit(ID, ISP_SC_REG, ISP_START_BIT);
- udelay(1);
-}
diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/isp_public.h b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/isp_public.h
index 78abd77c5..f778922f6 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/isp_public.h
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_include/host/isp_public.h
@@ -153,12 +153,4 @@ STORAGE_CLASS_ISP_H uint32_t isp_2w_cat_1w(
const u16 x0,
const uint16_t x1);
-unsigned int isp_is_ready(isp_ID_t ID);
-
-unsigned int isp_is_sleeping(isp_ID_t ID);
-
-void isp_start(isp_ID_t ID);
-
-void isp_wake(isp_ID_t ID);
-
#endif /* __ISP_PUBLIC_H_INCLUDED__ */
--
2.43.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2026-11-21 12:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-21 12:25 [PATCH] media: atomisp: Remove unused ISP state control functions Avishek Chaulagain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox