From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Dorine Tipo <dorine.a.tipo@gmail.com>,
gregkh@linuxfoundation.org, forest@alittletooquiet.net,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v3 1/1] staging: vt6655: Correct parameters alignment
Date: Mon, 4 Mar 2024 21:53:14 +0100 [thread overview]
Message-ID: <2ac49025-0cd0-4ea2-b06f-f1bfb5f8ee8f@gmail.com> (raw)
In-Reply-To: <20240304142603.32982-2-dorine.a.tipo@gmail.com>
On 3/4/24 15:26, Dorine Tipo wrote:
> Align parameters in static void calculate_ofdmr_parameter()
>
> This patch aligns the parameters with the opening parenthesis for better
> readability and adherence to coding style guidelines.
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
Hi Dorine,
please use only one Signed-off-by. See output of checkpatch:
WARNING: Duplicate signature
#19:
Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> Correct parameter alignment in bool card_update_tsf()
>
> This patch aligns the parameters with the opening parenthesis for better
> readability and adherence to coding style guidelines.
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
>
> Align parameters in card_get_tsf_offset()
>
> This patch aligns the 'local_tsf' parameter with the open parenthesis.
> This change improves code readability and maintains consistency with coding
> standards.
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
>
> Correct parameter alignment in bool card_set_beacon_period().
>
> This patch aligns the beacon_interval parameter with the opening
> parenthesis.
> This change improves code readability and adheres to coding style
> guidelines.
>
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> drivers/staging/vt6655/card.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
If you have just one patch you do not need a patch series. Omit the
cover letter.
In the description please do not describe what you did. Only write why
you did it.
Look under "git log" of your repo what is good.
Please insert a change history below the --- (You can take it from the
cover letter)
Thanks for your support.
Bye Philipp
next prev parent reply other threads:[~2024-03-04 20:53 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 6:56 [PATCH] staging: vt6655: Match parenthesis alignment Dorine Tipo
2024-03-03 19:30 ` Greg KH
2024-03-04 12:40 ` [PATCH v2 0/5] staging: Fix parameters alignment Dorine Tipo
2024-03-04 12:40 ` [PATCH v2 1/5] Staging: octeon: Match parenthesis alignment Dorine Tipo
2024-03-04 12:40 ` [PATCH v2 2/5] staging: vt6655: Correct parameters alignment Dorine Tipo
2024-03-04 12:40 ` [PATCH v2 3/5] staging: vt6655: Align parameters with parenthesis Dorine Tipo
2024-03-04 12:40 ` [PATCH v2 4/5] staging: vt6655: Match open parenthesis alignment Dorine Tipo
2024-03-04 12:40 ` [PATCH v2 5/5] staging: vt6655: Fix " Dorine Tipo
2024-03-04 13:55 ` [PATCH v2 0/5] staging: Fix parameters alignment Dan Carpenter
2024-03-04 14:26 ` [PATCH v3 0/1] Staging: vt6655: Parameter Alignment Improvements Dorine Tipo
2024-03-04 14:26 ` [PATCH v3 1/1] staging: vt6655: Correct parameters alignment Dorine Tipo
2024-03-04 20:53 ` Philipp Hortmann [this message]
2024-03-05 4:53 ` [PATCH v4] staging: vt6655: Match open parentheses Dorine Tipo
2024-03-05 8:10 ` [PATCH v3 1/1] staging: vt6655: Correct parameters alignment Dan Carpenter
2024-03-05 9:14 ` [PATCH v5] staging: vt6655: Match open parentheses Dorine Tipo
2024-03-05 9:32 ` [PATCH v6] " Dorine Tipo
2024-03-05 22:01 ` Philipp Hortmann
2024-03-06 4:59 ` Dan Carpenter
2024-03-06 5:40 ` Philipp Hortmann
2024-03-04 14:49 ` [PATCH V3] Staging: octeon: match parentheses alignment Dorine Tipo
2024-03-04 17:50 ` Greg KH
2024-03-05 5:14 ` [PATCH v4] Staging: octeon: Match parenthesis alignment Dorine Tipo
2024-03-05 9:23 ` [PATCH v5] " Dorine Tipo
2024-03-05 9:41 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ac49025-0cd0-4ea2-b06f-f1bfb5f8ee8f@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=dorine.a.tipo@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox