public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Dorine Tipo <dorine.a.tipo@gmail.com>,
	gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
	outreachy@lists.linux.dev
Subject: Re: [PATCH v6] staging: vt6655: Match open parentheses
Date: Tue, 5 Mar 2024 23:01:09 +0100	[thread overview]
Message-ID: <f76416c1-157f-4c31-8443-a63194a630be@gmail.com> (raw)
In-Reply-To: <20240305093213.4280-1-dorine.a.tipo@gmail.com>

On 3/5/24 10:32, Dorine Tipo wrote:
> Align the function parameters to silence a checkpatch warning.
> 
> Signed-off-by: Dorine Tipo<dorine.a.tipo@gmail.com>
> ---

Hi Dorine,
I tried to apply your patch but it failed. I do not really understand 
why. Have you edited the patch manually or was it created by git?

Thanks for your support.

Bye Philipp

git apply --reject --whitespace=fix ~/Downloads/20240305*
kernel@matrix-ESPRIMO-P710:~/Documents/git/kernels/staging$ git apply 
--reject --whitespace=fix ~/Downloads/20240305*
Checking patch drivers/staging/vt6655/card.c...
error: while searching for:
  * Return Value: none
  */
static void calculate_ofdmr_parameter(unsigned char rate,
				       u8 bb_type,
				       unsigned char *tx_rate,
				       unsigned char *rsv_time)
{
	switch (rate) {
	case RATE_6M:

error: patch failed: drivers/staging/vt6655/card.c:81
error: while searching for:
  * Return Value: none
  */
bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
		    u64 bss_timestamp)
{
	u64 local_tsf;
	u64 tsf_offset = 0;

error: patch failed: drivers/staging/vt6655/card.c:288
error: while searching for:

	if (bss_timestamp != local_tsf) {
		tsf_offset = card_get_tsf_offset(rx_rate, bss_timestamp,
						local_tsf);
		/* adjust TSF, HW's TSF add TSF Offset reg */
		tsf_offset =  le64_to_cpu(tsf_offset);
		iowrite32((u32)tsf_offset, priv->port_offset + MAC_REG_TSFOFST);

error: patch failed: drivers/staging/vt6655/card.c:297
error: while searching for:
  * Return Value: true if succeed; otherwise false
  */
bool card_set_beacon_period(struct vnt_private *priv,
			  unsigned short beacon_interval)
{
	u64 next_tbtt;


error: patch failed: drivers/staging/vt6655/card.c:321
Applying patch drivers/staging/vt6655/card.c with 4 rejects...
Rejected hunk #1.
Rejected hunk #2.
Rejected hunk #3.
Rejected hunk #4.


  reply	other threads:[~2024-03-05 22:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-03  6:56 [PATCH] staging: vt6655: Match parenthesis alignment Dorine Tipo
2024-03-03 19:30 ` Greg KH
2024-03-04 12:40   ` [PATCH v2 0/5] staging: Fix parameters alignment Dorine Tipo
2024-03-04 12:40     ` [PATCH v2 1/5] Staging: octeon: Match parenthesis alignment Dorine Tipo
2024-03-04 12:40     ` [PATCH v2 2/5] staging: vt6655: Correct parameters alignment Dorine Tipo
2024-03-04 12:40     ` [PATCH v2 3/5] staging: vt6655: Align parameters with parenthesis Dorine Tipo
2024-03-04 12:40     ` [PATCH v2 4/5] staging: vt6655: Match open parenthesis alignment Dorine Tipo
2024-03-04 12:40     ` [PATCH v2 5/5] staging: vt6655: Fix " Dorine Tipo
2024-03-04 13:55     ` [PATCH v2 0/5] staging: Fix parameters alignment Dan Carpenter
2024-03-04 14:26       ` [PATCH v3 0/1] Staging: vt6655: Parameter Alignment Improvements Dorine Tipo
2024-03-04 14:26         ` [PATCH v3 1/1] staging: vt6655: Correct parameters alignment Dorine Tipo
2024-03-04 20:53           ` Philipp Hortmann
2024-03-05  4:53             ` [PATCH v4] staging: vt6655: Match open parentheses Dorine Tipo
2024-03-05  8:10           ` [PATCH v3 1/1] staging: vt6655: Correct parameters alignment Dan Carpenter
2024-03-05  9:14           ` [PATCH v5] staging: vt6655: Match open parentheses Dorine Tipo
2024-03-05  9:32             ` [PATCH v6] " Dorine Tipo
2024-03-05 22:01               ` Philipp Hortmann [this message]
2024-03-06  4:59                 ` Dan Carpenter
2024-03-06  5:40                   ` Philipp Hortmann
2024-03-04 14:49       ` [PATCH V3] Staging: octeon: match parentheses alignment Dorine Tipo
2024-03-04 17:50         ` Greg KH
2024-03-05  5:14           ` [PATCH v4] Staging: octeon: Match parenthesis alignment Dorine Tipo
2024-03-05  9:23             ` [PATCH v5] " Dorine Tipo
2024-03-05  9:41               ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f76416c1-157f-4c31-8443-a63194a630be@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=dorine.a.tipo@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox