From: Benjamin Gaignard <benjamin.gaignard@collabora.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, kernel@collabora.com
Subject: Re: [PATCH v3 1/2] videobuf2: core: Rename min_buffers_needed field to vb2_queue
Date: Wed, 6 Dec 2023 12:59:24 +0100 [thread overview]
Message-ID: <34558f91-4253-4a1f-997c-1c8b02786fcb@collabora.com> (raw)
In-Reply-To: <a2011bd9-8d1d-486d-8a54-794193dc99ec@suswa.mountain>
Le 06/12/2023 à 10:54, Dan Carpenter a écrit :
> On Wed, Dec 06, 2023 at 09:56:07AM +0100, Benjamin Gaignard wrote:
>> Rename min_buffers_needed into min_queued_buffers and update
>> the documentation about it.
>>
>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> [ snip ]
>
>> diff --git a/drivers/media/pci/zoran/zoran_driver.c b/drivers/media/pci/zoran/zoran_driver.c
>> index fa672cc8bc67..2c91f75e8d79 100644
>> --- a/drivers/media/pci/zoran/zoran_driver.c
>> +++ b/drivers/media/pci/zoran/zoran_driver.c
>> @@ -749,9 +749,6 @@ static int zr_vb2_queue_setup(struct vb2_queue *vq, unsigned int *nbuffers, unsi
>>
>> zr->buf_in_reserve = 0;
>>
>> - if (*nbuffers < vq->min_buffers_needed)
>> - *nbuffers = vq->min_buffers_needed;
>> -
>> if (*nplanes) {
>> if (sizes[0] < size)
>> return -EINVAL;
> This was not mentioned in the commit message. And anyway, please do
> that as a separate commit.
It is a mistake, I don't want to change the drivers code.
I will restore these lines in next version.
Same for vdec driver below.
Regards,
Benjamin
>
> regards,
> dan carpenter
>
> _______________________________________________
> Kernel mailing list -- kernel@mailman.collabora.com
> To unsubscribe send an email to kernel-leave@mailman.collabora.com
next prev parent reply other threads:[~2023-12-06 11:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 8:56 [PATCH v3 0/2] Clean up min_buffers_needed misusages Benjamin Gaignard
2023-12-06 8:56 ` [PATCH v3 1/2] videobuf2: core: Rename min_buffers_needed field to vb2_queue Benjamin Gaignard
2023-12-06 9:54 ` Dan Carpenter
2023-12-06 11:59 ` Benjamin Gaignard [this message]
2023-12-06 8:56 ` [PATCH v3 2/2] videobuf2: Add min_reqbufs_allocation field to vb2_queue structure Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34558f91-4253-4a1f-997c-1c8b02786fcb@collabora.com \
--to=benjamin.gaignard@collabora.com \
--cc=dan.carpenter@linaro.org \
--cc=hverkuil@xs4all.nl \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox