* [PATCH v4] Staging: pi433: Updated bitrate range from datasheet
@ 2024-03-04 10:26 Aman Sharma
2024-03-05 14:12 ` Gregkh
0 siblings, 1 reply; 2+ messages in thread
From: Aman Sharma @ 2024-03-04 10:26 UTC (permalink / raw)
To: Gregkh; +Cc: linux-staging, linux-kernel
Updated bitrate range for FSK and OOK modulation from the RFM69
Datasheet.
The values are mentioned in Section 2.3.2 of the datasheet.
Signed-off-by: Aman Sharma <amansharma6122002@gmail.com>
---
V1->V2: Added explanation about values in commit msg
V2->V3: Added version comments after changelog
V3->V4: Corrected the Signed-off-by line
drivers/staging/pi433/Documentation/pi433.txt | 6 ++++--
drivers/staging/pi433/TODO | 1 -
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/pi433/Documentation/pi433.txt
b/drivers/staging/pi433/Documentation/pi433.txt
index 4a0d34b4ad37..9ce7282ef6f8 100644
--- a/drivers/staging/pi433/Documentation/pi433.txt
+++ b/drivers/staging/pi433/Documentation/pi433.txt
@@ -78,7 +78,8 @@ rf params:
Allowed values: 433050000...434790000
bit_rate
bit rate used for transmission.
- Allowed values: #####
+ Allowed values (For FSK): 1200...320000
+ Allowed values (For OOK): 1200...32768
dev_frequency
frequency deviation in case of FSK.
Allowed values: 600...500000
@@ -169,7 +170,8 @@ rf params:
Allowed values: 433050000...434790000
bit_rate
bit rate used for transmission.
- Allowed values: #####
+ Allowed values (For FSK): 1200...320000
+ Allowed values (For OOK): 1200...32768
dev_frequency
frequency deviation in case of FSK.
Allowed values: 600...500000
diff --git a/drivers/staging/pi433/TODO b/drivers/staging/pi433/TODO
index 63a40bfcc67e..61ed3a1578bc 100644
--- a/drivers/staging/pi433/TODO
+++ b/drivers/staging/pi433/TODO
@@ -2,4 +2,3 @@
* still TODOs, annotated in the code
* currently the code introduces new IOCTLs. I'm afraid this is a bad
idea.
-> Replace this with another interface, hints are welcome!
-* Some missing data (marked with ###) needs to be added in the
documentation
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v4] Staging: pi433: Updated bitrate range from datasheet
2024-03-04 10:26 [PATCH v4] Staging: pi433: Updated bitrate range from datasheet Aman Sharma
@ 2024-03-05 14:12 ` Gregkh
0 siblings, 0 replies; 2+ messages in thread
From: Gregkh @ 2024-03-05 14:12 UTC (permalink / raw)
To: Aman Sharma; +Cc: linux-staging, linux-kernel
On Mon, Mar 04, 2024 at 03:56:09PM +0530, Aman Sharma wrote:
> Updated bitrate range for FSK and OOK modulation from the RFM69 Datasheet.
> The values are mentioned in Section 2.3.2 of the datasheet.
>
> Signed-off-by: Aman Sharma <amansharma6122002@gmail.com>
> ---
> V1->V2: Added explanation about values in commit msg
> V2->V3: Added version comments after changelog
> V3->V4: Corrected the Signed-off-by line
>
> drivers/staging/pi433/Documentation/pi433.txt | 6 ++++--
> drivers/staging/pi433/TODO | 1 -
> 2 files changed, 4 insertions(+), 3 deletions(-)
This patch is corrupted and can not be applied :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-05 14:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-04 10:26 [PATCH v4] Staging: pi433: Updated bitrate range from datasheet Aman Sharma
2024-03-05 14:12 ` Gregkh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox