* Re: [linux-stable-rc:queue/5.15 78/106] drivers/staging/rtl8192e/rtl8192e/rtl_core.c:29:33: warning: unused variable 'rtl819xp_ops' [not found] <202305210810.njuOWlC1-lkp@intel.com> @ 2023-05-21 9:10 ` Philipp Hortmann 2023-05-22 16:52 ` Nick Desaulniers 0 siblings, 1 reply; 3+ messages in thread From: Philipp Hortmann @ 2023-05-21 9:10 UTC (permalink / raw) To: linux-staging@lists.linux.dev Cc: llvm, oe-kbuild-all, Sasha Levin, Greg Kroah-Hartman On 5/21/23 02:59, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git queue/5.15 > head: 632aeb02f8e831197a9a01b1e93cb00b4363be05 > commit: f13ecbca1796208fa2f888843223ea289f8e2b39 [78/106] staging: rtl8192e: Replace macro RTL_PCI_DEVICE with PCI_DEVICE > config: x86_64-allyesconfig > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=f13ecbca1796208fa2f888843223ea289f8e2b39 > git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > git fetch --no-tags linux-stable-rc queue/5.15 > git checkout f13ecbca1796208fa2f888843223ea289f8e2b39 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/x86/ drivers/staging/rtl8192e/rtl8192e/ > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot <lkp@intel.com> > | Closes: https://lore.kernel.org/oe-kbuild-all/202305210810.njuOWlC1-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > >>> drivers/staging/rtl8192e/rtl8192e/rtl_core.c:29:33: warning: unused variable 'rtl819xp_ops' [-Wunused-const-variable] > static const struct rtl819x_ops rtl819xp_ops = { > ^ > 1 warning generated. > > > vim +/rtl819xp_ops +29 drivers/staging/rtl8192e/rtl8192e/rtl_core.c > > 94a799425eee82 drivers/staging/rtl8192e/rtl_core.c Larry Finger 2011-08-23 27 > 94a799425eee82 drivers/staging/rtl8192e/rtl_core.c Larry Finger 2011-08-23 28 > 1c099ed63f8363 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Julia Lawall 2016-09-11 @29 static const struct rtl819x_ops rtl819xp_ops = { > 94a799425eee82 drivers/staging/rtl8192e/rtl_core.c Larry Finger 2011-08-23 30 .nic_type = NIC_8192E, > b095be37004f91 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 31 .get_eeprom_size = rtl92e_get_eeprom_size, > df85a1313fee7d drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 32 .init_adapter_variable = rtl92e_init_variables, > 460266292de1c3 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 33 .initialize_adapter = rtl92e_start_adapter, > b974b289c4cb8a drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 34 .link_change = rtl92e_link_change, > 072b3948d473f8 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 35 .tx_fill_descriptor = rtl92e_fill_tx_desc, > 63b544a17c63c0 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 36 .tx_fill_cmd_descriptor = rtl92e_fill_tx_cmd_desc, > 7897285ceb2864 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 37 .rx_query_status_descriptor = rtl92e_get_rx_stats, > 94a799425eee82 drivers/staging/rtl8192e/rtl_core.c Larry Finger 2011-08-23 38 .rx_command_packet_handler = NULL, > fe99c77b44e41c drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 39 .stop_adapter = rtl92e_stop_adapter, > 575d48c5753246 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 40 .update_ratr_table = rtl92e_update_ratr_table, > 6d99c68e6f5024 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 41 .irq_enable = rtl92e_enable_irq, > baadea565daae4 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 42 .irq_disable = rtl92e_disable_irq, > dc578b417facae drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 43 .irq_clear = rtl92e_clear_irq, > 78c352b2b22348 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 44 .rx_enable = rtl92e_enable_rx, > 6af7a8b662f6bb drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 45 .tx_enable = rtl92e_enable_tx, > a57165d15dae6f drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 46 .interrupt_recognized = rtl92e_ack_irq, > c9cf5e78f3b28e drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 47 .TxCheckStuckHandler = rtl92e_is_tx_stuck, > 4d73bd2636f51a drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 48 .RxCheckStuckHandler = rtl92e_is_rx_stuck, > 94a799425eee82 drivers/staging/rtl8192e/rtl_core.c Larry Finger 2011-08-23 49 }; > 94a799425eee82 drivers/staging/rtl8192e/rtl_core.c Larry Finger 2011-08-23 50 > > :::::: The code at line 29 was first introduced by commit > :::::: 1c099ed63f8363228a0b075a25511c9feb90e03f staging: rtl8192e: constify local structures > > :::::: TO: Julia Lawall <Julia.Lawall@lip6.fr> > :::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Hi, if anybody needs my help please let me know. I do not know what to do with this message. Thanks for your support. Bye Philipp ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [linux-stable-rc:queue/5.15 78/106] drivers/staging/rtl8192e/rtl8192e/rtl_core.c:29:33: warning: unused variable 'rtl819xp_ops' 2023-05-21 9:10 ` [linux-stable-rc:queue/5.15 78/106] drivers/staging/rtl8192e/rtl8192e/rtl_core.c:29:33: warning: unused variable 'rtl819xp_ops' Philipp Hortmann @ 2023-05-22 16:52 ` Nick Desaulniers 2023-05-23 18:36 ` Philipp Hortmann 0 siblings, 1 reply; 3+ messages in thread From: Nick Desaulniers @ 2023-05-22 16:52 UTC (permalink / raw) To: Philipp Hortmann, Greg Kroah-Hartman, Sasha Levin Cc: linux-staging@lists.linux.dev, llvm, oe-kbuild-all Hi Philipp, below is my interpretation of this report: On Sun, May 21, 2023 at 2:10 AM Philipp Hortmann <philipp.g.hortmann@gmail.com> wrote: > > On 5/21/23 02:59, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git queue/5.15 ^ So Greg and Sasha are cherry picking patches to linux-5.15.y branch of stable... > > head: 632aeb02f8e831197a9a01b1e93cb00b4363be05 > > commit: f13ecbca1796208fa2f888843223ea289f8e2b39 [78/106] staging: rtl8192e: Replace macro RTL_PCI_DEVICE with PCI_DEVICE ^ ...of the 106 patches picked up f13ecbca179620 is introducing a new failure... > > config: x86_64-allyesconfig ^ ...in allyesconfig builds... > > compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=f13ecbca1796208fa2f888843223ea289f8e2b39 > > git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git > > git fetch --no-tags linux-stable-rc queue/5.15 > > git checkout f13ecbca1796208fa2f888843223ea289f8e2b39 > > # save the config file > > mkdir build_dir && cp config build_dir/.config > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/x86/ drivers/staging/rtl8192e/rtl8192e/ > > > > If you fix the issue, kindly add following tag where applicable > > | Reported-by: kernel test robot <lkp@intel.com> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202305210810.njuOWlC1-lkp@intel.com/ > > > > All warnings (new ones prefixed by >>): > > > >>> drivers/staging/rtl8192e/rtl8192e/rtl_core.c:29:33: warning: unused variable 'rtl819xp_ops' [-Wunused-const-variable] ^ ... does Greg or Sasha need to pick up commit 5e2b6593f270 ("staging: rtl8192e: Remove empty struct rtl819x_ops") for linux-5.15.y in addition to f13ecbca1796208fa2f888843223ea289f8e2b39? 5e2b6593f270 lacks a fixes tag, so it's probably not obvious to them or their automation. > > static const struct rtl819x_ops rtl819xp_ops = { > > ^ > > 1 warning generated. > > > > > > vim +/rtl819xp_ops +29 drivers/staging/rtl8192e/rtl8192e/rtl_core.c > > > > 94a799425eee82 drivers/staging/rtl8192e/rtl_core.c Larry Finger 2011-08-23 27 > > 94a799425eee82 drivers/staging/rtl8192e/rtl_core.c Larry Finger 2011-08-23 28 > > 1c099ed63f8363 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Julia Lawall 2016-09-11 @29 static const struct rtl819x_ops rtl819xp_ops = { > > 94a799425eee82 drivers/staging/rtl8192e/rtl_core.c Larry Finger 2011-08-23 30 .nic_type = NIC_8192E, > > b095be37004f91 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 31 .get_eeprom_size = rtl92e_get_eeprom_size, > > df85a1313fee7d drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 32 .init_adapter_variable = rtl92e_init_variables, > > 460266292de1c3 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 33 .initialize_adapter = rtl92e_start_adapter, > > b974b289c4cb8a drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 34 .link_change = rtl92e_link_change, > > 072b3948d473f8 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 35 .tx_fill_descriptor = rtl92e_fill_tx_desc, > > 63b544a17c63c0 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 36 .tx_fill_cmd_descriptor = rtl92e_fill_tx_cmd_desc, > > 7897285ceb2864 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 37 .rx_query_status_descriptor = rtl92e_get_rx_stats, > > 94a799425eee82 drivers/staging/rtl8192e/rtl_core.c Larry Finger 2011-08-23 38 .rx_command_packet_handler = NULL, > > fe99c77b44e41c drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 39 .stop_adapter = rtl92e_stop_adapter, > > 575d48c5753246 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 40 .update_ratr_table = rtl92e_update_ratr_table, > > 6d99c68e6f5024 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 41 .irq_enable = rtl92e_enable_irq, > > baadea565daae4 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 42 .irq_disable = rtl92e_disable_irq, > > dc578b417facae drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 43 .irq_clear = rtl92e_clear_irq, > > 78c352b2b22348 drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 44 .rx_enable = rtl92e_enable_rx, > > 6af7a8b662f6bb drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 45 .tx_enable = rtl92e_enable_tx, > > a57165d15dae6f drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 46 .interrupt_recognized = rtl92e_ack_irq, > > c9cf5e78f3b28e drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 47 .TxCheckStuckHandler = rtl92e_is_tx_stuck, > > 4d73bd2636f51a drivers/staging/rtl8192e/rtl8192e/rtl_core.c Mateusz Kulikowski 2015-07-19 48 .RxCheckStuckHandler = rtl92e_is_rx_stuck, > > 94a799425eee82 drivers/staging/rtl8192e/rtl_core.c Larry Finger 2011-08-23 49 }; > > 94a799425eee82 drivers/staging/rtl8192e/rtl_core.c Larry Finger 2011-08-23 50 > > > > :::::: The code at line 29 was first introduced by commit > > :::::: 1c099ed63f8363228a0b075a25511c9feb90e03f staging: rtl8192e: constify local structures > > > > :::::: TO: Julia Lawall <Julia.Lawall@lip6.fr> > > :::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > Hi, > > if anybody needs my help please let me know. > > I do not know what to do with this message. > > Thanks for your support. > > Bye Philipp > > > -- Thanks, ~Nick Desaulniers ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [linux-stable-rc:queue/5.15 78/106] drivers/staging/rtl8192e/rtl8192e/rtl_core.c:29:33: warning: unused variable 'rtl819xp_ops' 2023-05-22 16:52 ` Nick Desaulniers @ 2023-05-23 18:36 ` Philipp Hortmann 0 siblings, 0 replies; 3+ messages in thread From: Philipp Hortmann @ 2023-05-23 18:36 UTC (permalink / raw) To: Nick Desaulniers, Greg Kroah-Hartman, Sasha Levin Cc: linux-staging@lists.linux.dev, llvm, oe-kbuild-all On 5/22/23 18:52, Nick Desaulniers wrote: > Hi Philipp, below is my interpretation of this report: > > On Sun, May 21, 2023 at 2:10 AM Philipp Hortmann > <philipp.g.hortmann@gmail.com> wrote: >> On 5/21/23 02:59, kernel test robot wrote: >>> tree:https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git queue/5.15 > ^ So Greg and Sasha are cherry picking patches to linux-5.15.y branch > of stable... > >>> head: 632aeb02f8e831197a9a01b1e93cb00b4363be05 >>> commit: f13ecbca1796208fa2f888843223ea289f8e2b39 [78/106] staging: rtl8192e: Replace macro RTL_PCI_DEVICE with PCI_DEVICE > ^ ...of the 106 patches picked up f13ecbca179620 is introducing a new failure... > >>> config: x86_64-allyesconfig > ^ ...in allyesconfig builds... > >>> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) >>> reproduce (this is a W=1 build): >>> wgethttps://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>> chmod +x ~/bin/make.cross >>> #https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=f13ecbca1796208fa2f888843223ea289f8e2b39 >>> git remote add linux-stable-rchttps://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git >>> git fetch --no-tags linux-stable-rc queue/5.15 >>> git checkout f13ecbca1796208fa2f888843223ea289f8e2b39 >>> # save the config file >>> mkdir build_dir && cp config build_dir/.config >>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig >>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/platform/x86/ drivers/staging/rtl8192e/rtl8192e/ >>> >>> If you fix the issue, kindly add following tag where applicable >>> | Reported-by: kernel test robot<lkp@intel.com> >>> | Closes:https://lore.kernel.org/oe-kbuild-all/202305210810.njuOWlC1-lkp@intel.com/ >>> >>> All warnings (new ones prefixed by >>): >>> >>>>> drivers/staging/rtl8192e/rtl8192e/rtl_core.c:29:33: warning: unused variable 'rtl819xp_ops' [-Wunused-const-variable] > ^ ... does Greg or Sasha need to pick up > commit 5e2b6593f270 ("staging: rtl8192e: Remove empty struct rtl819x_ops") > for linux-5.15.y in addition to f13ecbca1796208fa2f888843223ea289f8e2b39? > > 5e2b6593f270 lacks a fixes tag, so it's probably not obvious to them > or their automation. > Hi Nick, thanks for your response. The fix they applied does also not contain a fixes tag. If they want to get quit of this message they need to apply the patch you mentioned. Thanks Bye Philipp ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-23 18:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <202305210810.njuOWlC1-lkp@intel.com>
2023-05-21 9:10 ` [linux-stable-rc:queue/5.15 78/106] drivers/staging/rtl8192e/rtl8192e/rtl_core.c:29:33: warning: unused variable 'rtl819xp_ops' Philipp Hortmann
2023-05-22 16:52 ` Nick Desaulniers
2023-05-23 18:36 ` Philipp Hortmann
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox