From: Ira Weiny <ira.weiny@intel.com>
To: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>,
Julia Lawall <julia.lawall@inria.fr>
Cc: <gregkh@linuxfoundation.org>, <outreachy@lists.linux.dev>,
<martyn@welchs.me.uk>, <manohar.vanga@gmail.com>,
<zoo868e@gmail.com>, <jerrykang026@gmail.com>,
<cuigaosheng1@huawei.com>, <arnd@arndb.de>,
<linux-kernel@vger.kernel.org>, <linux-staging@lists.linux.dev>
Subject: Re: [PATCH v2 2/2] staging: vme_user: remove unnecessary blank lines
Date: Wed, 15 Mar 2023 12:22:27 -0700 [thread overview]
Message-ID: <64121af3e399e_253a1e294a2@iweiny-mobl.notmuch> (raw)
In-Reply-To: <b37352ef-959e-d950-c0c6-32e1c7268b79@gmail.com>
Menna Mahmoud wrote:
>
> On ١٥/٣/٢٠٢٣ ١٥:٤٥, Julia Lawall wrote:
> >
> > On Wed, 15 Mar 2023, Menna Mahmoud wrote:
> >
> >> remove unnecessary blank lines before a close brace
> >> as reported by checkpatch script
> >>
> >> "CHECK: Blank lines aren't necessary before a close brace '}'"
> >>
> >> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
> >> ----
> > This should be three -s, not four.
> >
> >> changes in v2:
> >> edit commit message
> >> ---
> > -s aren't needed here.
> >
> > julia
>
>
> I see, Thanks Julia
I agree with Julia that they are not needed here but they also don't hurt
anything. git format-patch (or b4 etc) add another '---' to the commit
message automatically.
https://lore.kernel.org/all/20221216-cxl-ev-log-v7-2-2316a5c8f7d8@intel.com/
So assuming you had something like ...
<quote>
----
changes in v2:
edit commit message
</quote>
... in the patch commit message. That is perfectly ok and I would not
worry about the tools adding a second '---'.
But as Julia said you must make sure to have only 3 '-'s. :-D
Ira
prev parent reply other threads:[~2023-03-15 19:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 13:43 [PATCH v2 1/2] staging: vme_user: add space around operators Menna Mahmoud
2023-03-15 13:43 ` [PATCH v2 2/2] staging: vme_user: remove unnecessary blank lines Menna Mahmoud
2023-03-15 13:45 ` Julia Lawall
2023-03-15 13:50 ` Menna Mahmoud
2023-03-15 19:22 ` Ira Weiny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64121af3e399e_253a1e294a2@iweiny-mobl.notmuch \
--to=ira.weiny@intel.com \
--cc=arnd@arndb.de \
--cc=cuigaosheng1@huawei.com \
--cc=eng.mennamahmoud.mm@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jerrykang026@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
--cc=outreachy@lists.linux.dev \
--cc=zoo868e@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox