From: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: gregkh@linuxfoundation.org, outreachy@lists.linux.dev,
martyn@welchs.me.uk, manohar.vanga@gmail.com, zoo868e@gmail.com,
jerrykang026@gmail.com, cuigaosheng1@huawei.com, arnd@arndb.de,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 2/2] staging: vme_user: remove unnecessary blank lines
Date: Wed, 15 Mar 2023 15:50:19 +0200 [thread overview]
Message-ID: <b37352ef-959e-d950-c0c6-32e1c7268b79@gmail.com> (raw)
In-Reply-To: <dcd9b79-bbd5-f160-317b-7fdd6ca6fc64@inria.fr>
On ١٥/٣/٢٠٢٣ ١٥:٤٥, Julia Lawall wrote:
>
> On Wed, 15 Mar 2023, Menna Mahmoud wrote:
>
>> remove unnecessary blank lines before a close brace
>> as reported by checkpatch script
>>
>> "CHECK: Blank lines aren't necessary before a close brace '}'"
>>
>> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
>> ----
> This should be three -s, not four.
>
>> changes in v2:
>> edit commit message
>> ---
> -s aren't needed here.
>
> julia
I see, Thanks Julia
Menna
>
>> drivers/staging/vme_user/vme_tsi148.c | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c
>> index bfa604043355..2f5eafd50934 100644
>> --- a/drivers/staging/vme_user/vme_tsi148.c
>> +++ b/drivers/staging/vme_user/vme_tsi148.c
>> @@ -1023,7 +1023,6 @@ static int tsi148_master_set(struct vme_master_resource *image, int enabled,
>> err_res:
>> err_window:
>> return retval;
>> -
>> }
>>
>> /*
>> @@ -1741,7 +1740,6 @@ static int tsi148_dma_list_add(struct vme_dma_list *list,
>> list);
>> prev->descriptor.dnlau = cpu_to_be32(address_high);
>> prev->descriptor.dnlal = cpu_to_be32(address_low);
>> -
>> }
>>
>> return 0;
>> @@ -1773,7 +1771,6 @@ static int tsi148_dma_busy(struct vme_bridge *tsi148_bridge, int channel)
>> return 0;
>> else
>> return 1;
>> -
>> }
>>
>> /*
>> @@ -2220,7 +2217,6 @@ static int tsi148_crcsr_init(struct vme_bridge *tsi148_bridge,
>> }
>>
>> return 0;
>> -
>> }
>>
>> static void tsi148_crcsr_exit(struct vme_bridge *tsi148_bridge,
>> @@ -2530,7 +2526,6 @@ static int tsi148_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>> kfree(tsi148_bridge);
>> err_struct:
>> return retval;
>> -
>> }
>>
>> static void tsi148_remove(struct pci_dev *pdev)
>> --
>> 2.34.1
>>
>>
>>
next prev parent reply other threads:[~2023-03-15 13:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 13:43 [PATCH v2 1/2] staging: vme_user: add space around operators Menna Mahmoud
2023-03-15 13:43 ` [PATCH v2 2/2] staging: vme_user: remove unnecessary blank lines Menna Mahmoud
2023-03-15 13:45 ` Julia Lawall
2023-03-15 13:50 ` Menna Mahmoud [this message]
2023-03-15 19:22 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b37352ef-959e-d950-c0c6-32e1c7268b79@gmail.com \
--to=eng.mennamahmoud.mm@gmail.com \
--cc=arnd@arndb.de \
--cc=cuigaosheng1@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=jerrykang026@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
--cc=outreachy@lists.linux.dev \
--cc=zoo868e@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox