[PATCH] staging: rtl8723bs: simplify boolean comparisons

[PATCH] staging: rtl8723bs: simplify boolean comparisons

[suryasaimadhu]

Avoid explicit comparisons to true/false, which are unnecessary
and can be error-prone. Replace them with direct boolean checks.

No functional change intended.

Signed-off-by: suryasaimadhu <suryasaimadhu369@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_ap.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 864cd8b6d1f1..6c29dc55b180 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -1013,10 +1013,10 @@ int rtw_check_beacon_data(struct adapter *padapter, u8 *pbuf,  int len)
 
 		rtw_ht_use_default_setting(padapter);
 
-		if (pmlmepriv->htpriv.sgi_20m == false)
+		if (!pmlmepriv->htpriv.sgi_20m)
 			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_20));
 
-		if (pmlmepriv->htpriv.sgi_40m == false)
+		if (!pmlmepriv->htpriv.sgi_40m)
 			pht_cap->cap_info &= cpu_to_le16(~(IEEE80211_HT_CAP_SGI_40));
 
 		if (!TEST_FLAG(pmlmepriv->htpriv.ldpc_cap, LDPC_HT_ENABLE_RX))
@@ -1156,7 +1156,7 @@ int rtw_acl_add_sta(struct adapter *padapter, u8 *addr)
 		paclnode = list_entry(plist, struct rtw_wlan_acl_node, list);
 
 		if (!memcmp(paclnode->addr, addr, ETH_ALEN)) {
-			if (paclnode->valid == true) {
+			if (paclnode->valid) {
 				added = true;
 				break;
 			}
-- 
2.47.3

Re: [PATCH] staging: rtl8723bs: simplify boolean comparisons

[Luka Gejak]

Hi suryasaimadhu,
I am sorry to inform you, but upon checking, I have discovered that 
your change was introduced in one patch in the past. You have probably
been working on master branch(one from Linus) and not staging-next. 
Therefore, since patch wasn't merged to mainline yet, you didn't see 
that your change is already present. Also one more thing to note for 
future contributions: in Signed-off-by tag you must use your real name
(Firstname Lastname <email>).
Best regards,
Luka Gejak