From: "Arnd Bergmann" <arnd@arndb.de>
To: "Phil Elwell" <phil@raspberrypi.com>
Cc: "laurent.pinchart" <laurent.pinchart@ideasonboard.com>,
"Stefan Wahren" <wahrenst@gmx.net>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>, "Christoph Hellwig" <hch@lst.de>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Robin Murphy" <robin.murphy@arm.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
linux-staging@lists.linux.dev
Subject: Re: WARNING: drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:364 vchiq_prepare_bulk_data
Date: Mon, 10 Jun 2024 12:09:57 +0200 [thread overview]
Message-ID: <857445de-23ee-4893-bddc-eebfcaec45f2@app.fastmail.com> (raw)
In-Reply-To: <CAMEGJJ30ffMSd40YpqGuMWOeazoT+oiDvzkYEc37jOTx4fZBNg@mail.gmail.com>
On Mon, Jun 10, 2024, at 11:24, Phil Elwell wrote:
> On Mon, 10 Jun 2024 at 10:20, Arnd Bergmann <arnd@arndb.de> wrote:
>>
>> My guess is that this will likely break existing applications,
>> in which case we cannot.
>>
>> It's probably a good idea to take a look at what buffers
>> are actually passed by userspace today. That would also
>> help decide how we allocate bounce buffers if we have to.
>> E.g. it's a big difference if the buffers are always
>> within a few bytes, kilobytes or megabytes.
>
> vchiq sends partial cache lines at the start and of reads (as seen
> from the ARM host) out of band, so the only misaligned DMA transfers
> should be from ARM to VPU. This should not require a bounce buffer.
Ok, so if the partial data is sent out of band already, it
may be possible to just leave it out of the scatterlist so
it doesn't get bounced by dma_map_sg().
I don't see where that case is handled but that shouldn't
be too hard here.
Arnd
next prev parent reply other threads:[~2024-06-10 10:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-09 22:24 WARNING: drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:364 vchiq_prepare_bulk_data Stefan Wahren
2024-06-10 6:00 ` Arnd Bergmann
2024-06-10 8:26 ` Phil Elwell
2024-06-10 9:00 ` Arnd Bergmann
2024-06-10 9:15 ` Laurent Pinchart
2024-06-10 9:19 ` Arnd Bergmann
2024-06-10 9:24 ` Phil Elwell
2024-06-10 10:09 ` Arnd Bergmann [this message]
2024-06-10 10:25 ` Robin Murphy
2024-06-11 10:47 ` Stefan Wahren
2024-06-11 11:08 ` Arnd Bergmann
2024-06-11 11:37 ` Stefan Wahren
2024-06-11 12:14 ` Arnd Bergmann
2024-06-11 13:09 ` Stefan Wahren
2024-06-11 13:35 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=857445de-23ee-4893-bddc-eebfcaec45f2@app.fastmail.com \
--to=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@raspberrypi.com \
--cc=robin.murphy@arm.com \
--cc=wahrenst@gmx.net \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox