From: Michal Simek <michal.simek@amd.com>
To: Grewstad <dogestad24@gmail.com>,
Dan Carpenter <error27@gmail.com>,
lucas.fariamo08@gmail.com
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev,
Ovidiu Panait <ovidiu.panait.oss@gmail.com>,
Jacob Feder <jacobsfeder@gmail.com>
Subject: Re: [PATCH] staging: axis-fifo: remove driver
Date: Wed, 3 Jun 2026 15:25:17 +0200 [thread overview]
Message-ID: <88df704d-438f-4298-850f-56c625f25624@amd.com> (raw)
In-Reply-To: <CAD03fja+rghsG=nY7zEZCO1RuX+ZEst92_U28xLoLv8YQMjf+g@mail.gmail.com>
+Lucas
On 6/3/26 14:25, Grewstad wrote:
> Adding Michal Simek, as he posted some relevant points in another thread.
>
> On Wed, Jun 3, 2026 at 1:49 PM Michal Simek <michal.simek@amd.com> wrote:
>>
>> Hi,
>>
>> On 6/1/26 09:15, Grewstad wrote:
>
>>
>> It is clear that driver in current state can't be used with axi ethernet out of
>> box because pretty much it is just about user interface for fifo via char device
>> fops. But we are talking about the same IP used in specific scenario and this
>> driver doesn't implement integration which can be used in ethernet driver.
>
>> I don't think you will find out any in-tree user because driver purpose is
>> different. It is about providing a user way via char device to push data to axi
>> streaming interface which can be consumed by user logic. It is generic way how
>> to push data there without writing specialized kernel driver for custom HW.
>> I think this is leaf driver which provide a way to axi fifo streaming interface
>
>> where stream is connected to custom HW which consumes it. I can understand that
>> this can be very useful for a lot of people who wants to process data from user
>> space via custom logic with using streaming interface.
>
>> And I don't have any issue to agree to move the driver out of staging to common
>> location.
>
> Thanks for letting me know. When you say common location, can you give your
> opinion on where it can be moved? We cannot find any user-space applications
> that use this driver, as you said it is a 'leaf driver'. Because of
> this, we do not know
> how it is used, who the end users are and hence we dont know where it
> can be moved.
We have drivers/misc/ for this purpose right?
There is attempt to move dt binding to yaml too but I can't see Lucas in this
thread.
https://lore.kernel.org/all/20260227181051.36207-1-lucas.fariamo08@gmail.com/
I was talking to our networking team and they have FIFO support on their plan
with axi ethernet.
Just a summary I am not convinced that this driver is in a state to be removed.
Thanks,
Michal
next prev parent reply other threads:[~2026-06-03 13:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 10:31 [PATCH] staging: axis-fifo: remove driver Arihan Bhor
2026-06-02 11:37 ` Dan Carpenter
2026-06-02 13:01 ` Grewstad
2026-06-02 13:11 ` Dan Carpenter
2026-06-02 21:26 ` Ovidiu Panait
2026-06-03 3:18 ` Grewstad
2026-06-03 3:20 ` Grewstad
2026-06-03 12:25 ` Grewstad
2026-06-03 13:25 ` Michal Simek [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-06-03 13:47 Denny Lin
2026-06-04 9:52 ` Grewstad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88df704d-438f-4298-850f-56c625f25624@amd.com \
--to=michal.simek@amd.com \
--cc=dogestad24@gmail.com \
--cc=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacobsfeder@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lucas.fariamo08@gmail.com \
--cc=ovidiu.panait.oss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox