Re: [PATCH] staging: greybus: remove camera driver marked as broken since 2016

[Alex Elder <elder@ieee.org>]

On 10/1/26 4:18 AM, Greg Kroah-Hartman wrote:
> On Fri, Sep 18, 2026 at 03:43:20PM +0300, Dan Carpenter wrote:
>> On Fri, Sep 18, 2026 at 07:18:54AM -0500, Alex Elder wrote:
>>> On 9/17/26 8:14 PM, Ethan Nelson-Moore wrote:
>>>> The Greybus camera driver has been marked as BROKEN since
>>>> commit d4f56b47a8fa ("staging: greybus: Add drivers/staging/greybus to
>>>> the build"). It has not been able to compile since at least
>>>> commit ec0ad868173d ("staging: greybus: move core include files to
>>>> include/linux/greybus/") because it includes greybus_protocols.h from
>>>> its own directory. These two facts make it very clear there is no
>>>> demand for this driver. Remove it from the kernel.
>>>
>>> Hmmm.  Do you know why it is BROKEN?  Do you know what it
>>> would take to make it work?  I understand the point of
>>> removing it, but in part the Greybus code has historically
>>> served as sample code for people to work on.  It might be
>>> nicer to have fixing it be a pet project.
>>>
>>
>> The compile breaks because of:
>>
>> commit aa1b4da6af67d5c6a4e933c2d30890c6f282f505
>> Author: Boris Brezillon <bbrezillon@kernel.org>
>> Date:   Mon Nov 10 14:28:35 2014 -0300
>>
>>      [media] v4l: Forbid usage of V4L2_MBUS_FMT definitions inside the kernel
>>      
>>      Place v4l2_mbus_pixelcode in a #ifndef __KERNEL__ section so that kernel
>>      users don't have access to these definitions.
> 
> Good point, no one has picked this up since then so let's drop the
> driver and if it ever is needed in the future it can be reverted and
> brought back.

It might be late to say so, but this sounds good to me (despite
my suggestion above).

					-Alex
  >
> thanks,
> 
> greg k-h