Linux kernel staging patches
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Alex Elder <elder@ieee.org>
Cc: Ethan Nelson-Moore <enelsonmoore@gmail.com>,
	greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
	Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] staging: greybus: remove camera driver marked as broken since 2016
Date: Fri, 18 Sep 2026 15:43:20 +0300	[thread overview]
Message-ID: <aq0x6IGnKd2IYXoU@stanley.mountain> (raw)
In-Reply-To: <3f152ed6-e572-4c96-8762-2fb7cdc77695@ieee.org>

On Fri, Sep 18, 2026 at 07:18:54AM -0500, Alex Elder wrote:
> On 9/17/26 8:14 PM, Ethan Nelson-Moore wrote:
> > The Greybus camera driver has been marked as BROKEN since
> > commit d4f56b47a8fa ("staging: greybus: Add drivers/staging/greybus to
> > the build"). It has not been able to compile since at least
> > commit ec0ad868173d ("staging: greybus: move core include files to
> > include/linux/greybus/") because it includes greybus_protocols.h from
> > its own directory. These two facts make it very clear there is no
> > demand for this driver. Remove it from the kernel.
> 
> Hmmm.  Do you know why it is BROKEN?  Do you know what it
> would take to make it work?  I understand the point of
> removing it, but in part the Greybus code has historically
> served as sample code for people to work on.  It might be
> nicer to have fixing it be a pet project.
> 

The compile breaks because of:

commit aa1b4da6af67d5c6a4e933c2d30890c6f282f505
Author: Boris Brezillon <bbrezillon@kernel.org>
Date:   Mon Nov 10 14:28:35 2014 -0300

    [media] v4l: Forbid usage of V4L2_MBUS_FMT definitions inside the kernel
    
    Place v4l2_mbus_pixelcode in a #ifndef __KERNEL__ section so that kernel
    users don't have access to these definitions.

regards,
dan carpenter


  reply	other threads:[~2026-09-18 12:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18  1:14 [PATCH] staging: greybus: remove camera driver marked as broken since 2016 Ethan Nelson-Moore
2026-09-18 12:18 ` Alex Elder
2026-09-18 12:43   ` Dan Carpenter [this message]
2026-10-01  9:18     ` Greg Kroah-Hartman
2026-10-01  9:37       ` [greybus-dev] " Ayush Singh
2026-10-01  9:55       ` Ayush Singh
2026-10-01 20:39       ` Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aq0x6IGnKd2IYXoU@stanley.mountain \
    --to=error27@gmail.com \
    --cc=elder@ieee.org \
    --cc=elder@kernel.org \
    --cc=enelsonmoore@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox