From: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
To: Alison Schofield <alison.schofield@intel.com>
Cc: outreachy@lists.linux.dev, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging:rtl8723bs:rtw_cmd.c remove suspect indent
Date: Wed, 30 Mar 2022 19:38:47 +0200 [thread overview]
Message-ID: <9e6abf4a-cf5c-05c9-b179-b863ef53f35f@gmail.com> (raw)
In-Reply-To: <20220330170936.GA1176693@alison-desk>
On ٣٠/٣/٢٠٢٢ ١٩:٠٩, Alison Schofield wrote:
> On Wed, Mar 30, 2022 at 05:31:00PM +0200, Alaa Mohamed wrote:
>> Fix "WARNING: suspect code indent for conditional
>> statements (16, 32)" for line 1240
>> founded by checkpatch.pl
>>
>> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> Hi Alaa,
>
> https://kernelnewbies.org/PatchPhilosophy
> Please take a look at the section on "Patch subject formatting"
> and the follow on sections about checkpatch descriptions.
I will check , Thank you
>
> Thanks,
> Alison
>
>
>> ---
>> drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
>> index 14d37b369273..46e18a90529f 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
>> @@ -1238,7 +1238,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer)
>> /*&& !MgntInitAdapterInProgress(pMgntInfo)*/) {
>> /* if we raise bBusyTraffic in last watchdog, using lower threshold. */
>> if (pmlmepriv->LinkDetectInfo.bBusyTraffic)
>> - BusyThreshold = BusyThresholdLow;
>> + BusyThreshold = BusyThresholdLow;
>>
>> if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > BusyThreshold ||
>> pmlmepriv->LinkDetectInfo.NumTxOkInPeriod > BusyThreshold) {
>> --
>> 2.35.1
>>
>>
prev parent reply other threads:[~2022-03-30 17:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 15:31 [PATCH] staging:rtl8723bs:rtw_cmd.c remove suspect indent Alaa Mohamed
2022-03-30 17:09 ` Alison Schofield
2022-03-30 17:38 ` Alaa Mohamed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e6abf4a-cf5c-05c9-b179-b863ef53f35f@gmail.com \
--to=eng.alaamohamedsoliman.am@gmail.com \
--cc=alison.schofield@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox