* [PATCH] staging:rtl8723bs:rtw_cmd.c remove suspect indent
@ 2022-03-30 15:31 Alaa Mohamed
2022-03-30 17:09 ` Alison Schofield
0 siblings, 1 reply; 3+ messages in thread
From: Alaa Mohamed @ 2022-03-30 15:31 UTC (permalink / raw)
To: outreachy; +Cc: gregkh, linux-staging, linux-kernel, eng.alaamohamedsoliman.am
Fix "WARNING: suspect code indent for conditional
statements (16, 32)" for line 1240
founded by checkpatch.pl
Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index 14d37b369273..46e18a90529f 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -1238,7 +1238,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer)
/*&& !MgntInitAdapterInProgress(pMgntInfo)*/) {
/* if we raise bBusyTraffic in last watchdog, using lower threshold. */
if (pmlmepriv->LinkDetectInfo.bBusyTraffic)
- BusyThreshold = BusyThresholdLow;
+ BusyThreshold = BusyThresholdLow;
if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > BusyThreshold ||
pmlmepriv->LinkDetectInfo.NumTxOkInPeriod > BusyThreshold) {
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging:rtl8723bs:rtw_cmd.c remove suspect indent
2022-03-30 15:31 [PATCH] staging:rtl8723bs:rtw_cmd.c remove suspect indent Alaa Mohamed
@ 2022-03-30 17:09 ` Alison Schofield
2022-03-30 17:38 ` Alaa Mohamed
0 siblings, 1 reply; 3+ messages in thread
From: Alison Schofield @ 2022-03-30 17:09 UTC (permalink / raw)
To: Alaa Mohamed; +Cc: outreachy, gregkh, linux-staging, linux-kernel
On Wed, Mar 30, 2022 at 05:31:00PM +0200, Alaa Mohamed wrote:
> Fix "WARNING: suspect code indent for conditional
> statements (16, 32)" for line 1240
> founded by checkpatch.pl
>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
Hi Alaa,
https://kernelnewbies.org/PatchPhilosophy
Please take a look at the section on "Patch subject formatting"
and the follow on sections about checkpatch descriptions.
Thanks,
Alison
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index 14d37b369273..46e18a90529f 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -1238,7 +1238,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer)
> /*&& !MgntInitAdapterInProgress(pMgntInfo)*/) {
> /* if we raise bBusyTraffic in last watchdog, using lower threshold. */
> if (pmlmepriv->LinkDetectInfo.bBusyTraffic)
> - BusyThreshold = BusyThresholdLow;
> + BusyThreshold = BusyThresholdLow;
>
> if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > BusyThreshold ||
> pmlmepriv->LinkDetectInfo.NumTxOkInPeriod > BusyThreshold) {
> --
> 2.35.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging:rtl8723bs:rtw_cmd.c remove suspect indent
2022-03-30 17:09 ` Alison Schofield
@ 2022-03-30 17:38 ` Alaa Mohamed
0 siblings, 0 replies; 3+ messages in thread
From: Alaa Mohamed @ 2022-03-30 17:38 UTC (permalink / raw)
To: Alison Schofield; +Cc: outreachy, gregkh, linux-staging, linux-kernel
On ٣٠/٣/٢٠٢٢ ١٩:٠٩, Alison Schofield wrote:
> On Wed, Mar 30, 2022 at 05:31:00PM +0200, Alaa Mohamed wrote:
>> Fix "WARNING: suspect code indent for conditional
>> statements (16, 32)" for line 1240
>> founded by checkpatch.pl
>>
>> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> Hi Alaa,
>
> https://kernelnewbies.org/PatchPhilosophy
> Please take a look at the section on "Patch subject formatting"
> and the follow on sections about checkpatch descriptions.
I will check , Thank you
>
> Thanks,
> Alison
>
>
>> ---
>> drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
>> index 14d37b369273..46e18a90529f 100644
>> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
>> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
>> @@ -1238,7 +1238,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer)
>> /*&& !MgntInitAdapterInProgress(pMgntInfo)*/) {
>> /* if we raise bBusyTraffic in last watchdog, using lower threshold. */
>> if (pmlmepriv->LinkDetectInfo.bBusyTraffic)
>> - BusyThreshold = BusyThresholdLow;
>> + BusyThreshold = BusyThresholdLow;
>>
>> if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > BusyThreshold ||
>> pmlmepriv->LinkDetectInfo.NumTxOkInPeriod > BusyThreshold) {
>> --
>> 2.35.1
>>
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-30 17:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-30 15:31 [PATCH] staging:rtl8723bs:rtw_cmd.c remove suspect indent Alaa Mohamed
2022-03-30 17:09 ` Alison Schofield
2022-03-30 17:38 ` Alaa Mohamed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox