From: "Luka Gejak" <luka.gejak@linux.dev>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Marc Finkelbaum" <regpacy@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Michael Straube" <straube.linux@gmail.com>,
"Dan Carpenter" <dan.carpenter@linaro.org>,
"Ethan Tidmore" <ethantidmore06@gmail.com>,
<linux-staging@lists.linux.dev>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/9] staging: rtl8723bs: fix Yoda conditions and == false comparisons
Date: Tue, 14 Apr 2026 20:25:51 +0200 [thread overview]
Message-ID: <DHT37Q73Q6XI.2OOT8UCWAD7TD@linux.dev> (raw)
In-Reply-To: <ad4xYmCJGXuLVJWM@ashevche-desk.local>
On Tue Apr 14, 2026 at 2:21 PM CEST, Andy Shevchenko wrote:
> On Tue, Apr 14, 2026 at 12:58:30PM +0300, Marc Finkelbaum wrote:
>> Replace reversed comparisons with natural-order equivalents:
>> - '0xFF == hw_channel_plan' -> 'hw_channel_plan == 0xFF'
>> - 'false == pHalData->bDisableSWChannelPlan' -> '!pHalData->...'
>> - 'is_supported_24g(...) == false' -> '!is_supported_24g(...)'
>>
>> The multi-line if condition around bDisableSWChannelPlan is also
>> reformatted to standard kernel one-line style.
>>
>> No functional change.
>
> ...
>
>> - if (
>> - (false == pHalData->bDisableSWChannelPlan) &&
>> - rtw_is_channel_plan_valid(sw_channel_plan)
>> - )
>> + if ((!pHalData->bDisableSWChannelPlan) &&
>
> Too many parentheses.
Also does too many things at once(reversing yoda style, simplifying
boolean expresions) therefore should be splited to 2 patches addressing
2 different types of cleanups.
Best regards,
Luka Gejak
>
>> + rtw_is_channel_plan_valid(sw_channel_plan))
>> chnlPlan = sw_channel_plan;
next prev parent reply other threads:[~2026-04-14 18:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 9:58 [PATCH 0/9] staging: rtl8723bs: coding style cleanup in hal_com.c Marc Finkelbaum
2026-04-14 9:58 ` [PATCH 1/9] staging: rtl8723bs: remove extra blank lines Marc Finkelbaum
2026-04-14 11:45 ` Andy Shevchenko
2026-04-14 9:58 ` [PATCH 2/9] staging: rtl8723bs: fix space-before-tab whitespace Marc Finkelbaum
2026-04-14 11:48 ` Andy Shevchenko
2026-04-14 9:58 ` [PATCH 3/9] staging: rtl8723bs: fix block comment alignment Marc Finkelbaum
2026-04-14 11:51 ` Andy Shevchenko
2026-04-14 9:58 ` [PATCH 4/9] staging: rtl8723bs: add spaces around binary operators Marc Finkelbaum
2026-04-14 11:58 ` Andy Shevchenko
2026-04-14 9:58 ` [PATCH 5/9] staging: rtl8723bs: add space before inline block comments Marc Finkelbaum
2026-04-14 12:12 ` Andy Shevchenko
2026-04-14 9:58 ` [PATCH 6/9] staging: rtl8723bs: fix Yoda conditions and == false comparisons Marc Finkelbaum
2026-04-14 12:21 ` Andy Shevchenko
2026-04-14 18:25 ` Luka Gejak [this message]
2026-04-14 9:58 ` [PATCH 7/9] staging: rtl8723bs: reformat multi-line function signatures Marc Finkelbaum
2026-04-14 9:58 ` [PATCH 8/9] staging: rtl8723bs: reformat switch-case blocks with braced bodies Marc Finkelbaum
2026-04-14 9:58 ` [PATCH 9/9] staging: rtl8723bs: wrap long lines and fix argument alignment Marc Finkelbaum
2026-04-14 12:31 ` Andy Shevchenko
2026-04-14 16:08 ` [PATCH 0/9] staging: rtl8723bs: coding style cleanup in hal_com.c regpac youtube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DHT37Q73Q6XI.2OOT8UCWAD7TD@linux.dev \
--to=luka.gejak@linux.dev \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.carpenter@linaro.org \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=regpacy@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox