* [PATCH] staging: rtl8723bs: os_dep: remove unnecessary braces for single statement
@ 2026-04-18 17:19 Shyam Sunder Reddy Padira
2026-04-18 18:08 ` Josh Law
2026-04-21 14:18 ` Luka Gejak
0 siblings, 2 replies; 3+ messages in thread
From: Shyam Sunder Reddy Padira @ 2026-04-18 17:19 UTC (permalink / raw)
To: gregkh, linux-staging, linux-kernel; +Cc: Shyam Sunder Reddy Padira
Remove redundant braces around single statement blocks to follow
kernel coding style and improve readability.
Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index d664e254912c..a86252ccac76 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -146,9 +146,8 @@ static void sdio_deinit(struct dvobj_priv *dvobj)
sdio_claim_host(func);
sdio_disable_func(func);
- if (dvobj->irq_alloc) {
+ if (dvobj->irq_alloc)
sdio_release_irq(func);
- }
sdio_release_host(func);
}
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: os_dep: remove unnecessary braces for single statement
2026-04-18 17:19 [PATCH] staging: rtl8723bs: os_dep: remove unnecessary braces for single statement Shyam Sunder Reddy Padira
@ 2026-04-18 18:08 ` Josh Law
2026-04-21 14:18 ` Luka Gejak
1 sibling, 0 replies; 3+ messages in thread
From: Josh Law @ 2026-04-18 18:08 UTC (permalink / raw)
To: shyamsunderreddypadira; +Cc: gregkh, linux-kernel, linux-staging
Hello shyam.
Seems good enough to me
Reviewed-by: Josh Law <joshlaw48@gmail.com>
If you like this file, feel free to check the TODO file!
(I'm not the driver maintainer or anything btw! Sorry if this is
disturbing the maintainers or anything)
V/R
Josh Law
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: rtl8723bs: os_dep: remove unnecessary braces for single statement
2026-04-18 17:19 [PATCH] staging: rtl8723bs: os_dep: remove unnecessary braces for single statement Shyam Sunder Reddy Padira
2026-04-18 18:08 ` Josh Law
@ 2026-04-21 14:18 ` Luka Gejak
1 sibling, 0 replies; 3+ messages in thread
From: Luka Gejak @ 2026-04-21 14:18 UTC (permalink / raw)
To: Shyam Sunder Reddy Padira, gregkh, linux-staging, linux-kernel
On Sat Apr 18, 2026 at 7:19 PM CEST, Shyam Sunder Reddy Padira wrote:
> Remove redundant braces around single statement blocks to follow
> kernel coding style and improve readability.
>
> Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
> ---
> drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> index d664e254912c..a86252ccac76 100644
> --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
> @@ -146,9 +146,8 @@ static void sdio_deinit(struct dvobj_priv *dvobj)
> sdio_claim_host(func);
> sdio_disable_func(func);
>
> - if (dvobj->irq_alloc) {
> + if (dvobj->irq_alloc)
> sdio_release_irq(func);
> - }
>
> sdio_release_host(func);
> }
LGTM.
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-21 14:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-18 17:19 [PATCH] staging: rtl8723bs: os_dep: remove unnecessary braces for single statement Shyam Sunder Reddy Padira
2026-04-18 18:08 ` Josh Law
2026-04-21 14:18 ` Luka Gejak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox