[PATCH] staging: greybus: fw-management: fix argument alignment

[PATCH] staging: greybus: fw-management: fix argument alignment

[Okhuomon Ajayi]

Align the arguments of the fw_mgmt_load_and_validate_operation()
call with the opening parenthesis and split them across separate
lines to avoid an overly long line.

CHECK: Alignment should match open parenthesis

Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
---
 drivers/staging/greybus/fw-management.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/fw-management.c b/drivers/staging/greybus/fw-management.c
index 5d01da6b6eb9..e20e9136c106 100644
--- a/drivers/staging/greybus/fw-management.c
+++ b/drivers/staging/greybus/fw-management.c
@@ -434,7 +434,8 @@ static int fw_mgmt_ioctl(struct fw_mgmt *fw_mgmt, unsigned int cmd,
 			return -EFAULT;
 
 		ret = fw_mgmt_load_and_validate_operation(fw_mgmt,
-				intf_load.load_method, intf_load.firmware_tag);
+							  intf_load.load_method,
+							  intf_load.firmware_tag);
 		if (ret)
 			return ret;
 
-- 
2.43.0

Re: [PATCH] staging: greybus: fw-management: fix argument alignment

[Ethan Tidmore]

On Sun Oct 18, 2026 at 5:42 PM CDT, Okhuomon Ajayi wrote:
> Align the arguments of the fw_mgmt_load_and_validate_operation()
> call with the opening parenthesis and split them across separate
> lines to avoid an overly long line.
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
> ---

LGTM.

Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>

Thanks,
ET

Re: [PATCH] staging: greybus: fw-management: fix argument alignment

[Alex Elder]

On 10/18/26 5:42 PM, Okhuomon Ajayi wrote:
> Align the arguments of the fw_mgmt_load_and_validate_operation()
> call with the opening parenthesis and split them across separate
> lines to avoid an overly long line.
> 
> CHECK: Alignment should match open parenthesis

So this was found with "make C=1".  And the checker tool used
was sparse?  If so, that bit of context for this message would
be helpful to add.

Also, I tend to ask this a log on these small one-off patches:
Are there any other instances you see of this particular
warning?  I *know* not all of them can be fixed as neatly
as this one, but are there cases where aligning arguments
this way still preserves readability?  (Greybus code also
generally fits within 80 columns.)

If there are, I think it would be good to fix them together
(in one patch, or possibly in a series, one per file).

Other than those comments, this change looks good to me.

Reviewed-by: Alex Elder <elder@riscstar.com>

> Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
> ---
>   drivers/staging/greybus/fw-management.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/fw-management.c b/drivers/staging/greybus/fw-management.c
> index 5d01da6b6eb9..e20e9136c106 100644
> --- a/drivers/staging/greybus/fw-management.c
> +++ b/drivers/staging/greybus/fw-management.c
> @@ -434,7 +434,8 @@ static int fw_mgmt_ioctl(struct fw_mgmt *fw_mgmt, unsigned int cmd,
>   			return -EFAULT;
>   
>   		ret = fw_mgmt_load_and_validate_operation(fw_mgmt,
> -				intf_load.load_method, intf_load.firmware_tag);
> +							  intf_load.load_method,
> +							  intf_load.firmware_tag);
>   		if (ret)
>   			return ret;
>