* [PATCH] staging: pi433: call set_lan_gain for receiver config
@ 2022-11-19 17:11 Deepak R Varma
2022-11-22 12:08 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Deepak R Varma @ 2022-11-19 17:11 UTC (permalink / raw)
To: Greg Kroah-Hartman, linux-staging, linux-kernel; +Cc: drv
Value for the LNA gain is captured from the user as part of the struct
pi433_rx_cfg, however, the corresponding function rf69_set_lna_gain() is
never called to set it. Include a call to this function as part of
setting up the rx configurations.
Signed-off-by: Deepak R Varma <drv@mailo.com>
---
drivers/staging/pi433/pi433_if.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index d4e06a3929f3..e588a98d7f33 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -176,6 +176,9 @@ rf69_set_rx_cfg(struct pi433_device *dev, struct pi433_rx_cfg *rx_cfg)
if (ret < 0)
return ret;
ret = rf69_set_antenna_impedance(dev->spi, rx_cfg->antenna_impedance);
+ if (ret < 0)
+ return ret;
+ ret = rf69_set_lna_gain(dev->spi, rx_cfg->lna_gain);
if (ret < 0)
return ret;
ret = rf69_set_rssi_threshold(dev->spi, rx_cfg->rssi_threshold);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: pi433: call set_lan_gain for receiver config
2022-11-19 17:11 [PATCH] staging: pi433: call set_lan_gain for receiver config Deepak R Varma
@ 2022-11-22 12:08 ` Greg Kroah-Hartman
2022-11-22 12:29 ` Deepak R Varma
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2022-11-22 12:08 UTC (permalink / raw)
To: Deepak R Varma; +Cc: linux-staging, linux-kernel
On Sat, Nov 19, 2022 at 10:41:17PM +0530, Deepak R Varma wrote:
> Value for the LNA gain is captured from the user as part of the struct
> pi433_rx_cfg, however, the corresponding function rf69_set_lna_gain() is
> never called to set it. Include a call to this function as part of
> setting up the rx configurations.
>
> Signed-off-by: Deepak R Varma <drv@mailo.com>
> ---
> drivers/staging/pi433/pi433_if.c | 3 +++
> 1 file changed, 3 insertions(+)
How was this change tested?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: pi433: call set_lan_gain for receiver config
2022-11-22 12:08 ` Greg Kroah-Hartman
@ 2022-11-22 12:29 ` Deepak R Varma
0 siblings, 0 replies; 3+ messages in thread
From: Deepak R Varma @ 2022-11-22 12:29 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel
On Tue, Nov 22, 2022 at 01:08:31PM +0100, Greg Kroah-Hartman wrote:
> On Sat, Nov 19, 2022 at 10:41:17PM +0530, Deepak R Varma wrote:
> > Value for the LNA gain is captured from the user as part of the struct
> > pi433_rx_cfg, however, the corresponding function rf69_set_lna_gain() is
> > never called to set it. Include a call to this function as part of
> > setting up the rx configurations.
> >
> > Signed-off-by: Deepak R Varma <drv@mailo.com>
> > ---
> > drivers/staging/pi433/pi433_if.c | 3 +++
> > 1 file changed, 3 insertions(+)
>
> How was this change tested?
Hi Greg,
This was compile tested only.
As per your message on the other patch for this driver, I am holding back such
patches until I have the ability to test the change with a real device myself.
I most welcome if there is any other feedback on the patches. It will help me
consolidate the feedback and react to them in one go.
Thank you,
./drv
>
> thanks,
>
> greg k-h
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-22 12:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-19 17:11 [PATCH] staging: pi433: call set_lan_gain for receiver config Deepak R Varma
2022-11-22 12:08 ` Greg Kroah-Hartman
2022-11-22 12:29 ` Deepak R Varma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox