[PATCH] staging: wlan-ng: fix checkpatch error for spinlock

[PATCH] staging: wlan-ng: fix checkpatch error for spinlock

[Dalvin Aiguobas]

Checkpatch Styleproblem fixed by adding comment.

Signed-off-by: Dalvin <pharcodra@gmail.com>
---
 drivers/staging/wlan-ng/hfa384x.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 0611e37df6ac..ad117d570bb6 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1171,6 +1171,7 @@ struct hfa384x_usbctlx {
 };
 
 struct hfa384x_usbctlxq {
+	/* lock: Protect structure fields */
 	spinlock_t lock;
 	struct list_head pending;
 	struct list_head active;
-- 
2.25.1

Re: [PATCH] staging: wlan-ng: fix checkpatch error for spinlock

[Greg Kroah-Hartman]

On Sun, Dec 11, 2022 at 11:56:49AM +0100, Dalvin Aiguobas wrote:
> Checkpatch Styleproblem fixed by adding comment.
> 
> Signed-off-by: Dalvin <pharcodra@gmail.com>
> ---
>  drivers/staging/wlan-ng/hfa384x.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> index 0611e37df6ac..ad117d570bb6 100644
> --- a/drivers/staging/wlan-ng/hfa384x.h
> +++ b/drivers/staging/wlan-ng/hfa384x.h
> @@ -1171,6 +1171,7 @@ struct hfa384x_usbctlx {
>  };
>  
>  struct hfa384x_usbctlxq {
> +	/* lock: Protect structure fields */
>  	spinlock_t lock;
>  	struct list_head pending;
>  	struct list_head active;
> -- 
> 2.25.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

- It looks like you did not use your "real" name for the patch on either
  the Signed-off-by: line, or the From: line (both of which have to
  match).  Please read the kernel file, Documentation/SubmittingPatches
  for how to do this correctly.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Re: [PATCH] staging: wlan-ng: fix checkpatch error for spinlock

[Greg Kroah-Hartman]

On Sun, Dec 11, 2022 at 12:06:04PM +0100, Greg Kroah-Hartman wrote:
> On Sun, Dec 11, 2022 at 11:56:49AM +0100, Dalvin Aiguobas wrote:
> > Checkpatch Styleproblem fixed by adding comment.
> > 
> > Signed-off-by: Dalvin <pharcodra@gmail.com>
> > ---
> >  drivers/staging/wlan-ng/hfa384x.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
> > index 0611e37df6ac..ad117d570bb6 100644
> > --- a/drivers/staging/wlan-ng/hfa384x.h
> > +++ b/drivers/staging/wlan-ng/hfa384x.h
> > @@ -1171,6 +1171,7 @@ struct hfa384x_usbctlx {
> >  };
> >  
> >  struct hfa384x_usbctlxq {
> > +	/* lock: Protect structure fields */

Also, does this comment really make sense?  To properly document a lock
takes a bit more text, if you read this would it help out in
understanding the code any?

thanks,

greg k-h