* [PATCH] staging: pi433: Added information about bit_rate configuration
@ 2023-01-31 18:14 Guru Mehar Rachaputi
2023-02-01 6:16 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Guru Mehar Rachaputi @ 2023-01-31 18:14 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging, linux-kernel
Information in the TODO file for bit_rate configuration is
insufficient.
This patch adds information on how to approach when considering
to modify bit_rate to support upto 300kbps.
Signed-off-by: Guru Mehar Rachaputi <gurumeharrachaputi@gmail.com>
---
drivers/staging/pi433/TODO | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/pi433/TODO b/drivers/staging/pi433/TODO
index 5cf3fd99d521..daa0dbcf6d53 100644
--- a/drivers/staging/pi433/TODO
+++ b/drivers/staging/pi433/TODO
@@ -3,3 +3,6 @@
* Some missing data (marked with ###) needs to be added in the documentation
* Change (struct pi433_tx_cfg)->bit_rate to be a u32 so that we can support
bit rates up to 300kbps per the spec.
+ -> This configuration needs to be moved to sysfs instead of being done through
+ IOCTL. Goind forward, we need to port userspace tools to use sysfs instead
+ of IOCTL and then we would delete IOCTL.
--
2.34.1
--
Thanks & Regards,
Guru
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: pi433: Added information about bit_rate configuration
2023-01-31 18:14 [PATCH] staging: pi433: Added information about bit_rate configuration Guru Mehar Rachaputi
@ 2023-02-01 6:16 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2023-02-01 6:16 UTC (permalink / raw)
To: Guru Mehar Rachaputi; +Cc: Greg Kroah-Hartman, linux-staging, linux-kernel
On Tue, Jan 31, 2023 at 07:14:39PM +0100, Guru Mehar Rachaputi wrote:
> Information in the TODO file for bit_rate configuration is
> insufficient.
>
> This patch adds information on how to approach when considering
> to modify bit_rate to support upto 300kbps.
>
> Signed-off-by: Guru Mehar Rachaputi <gurumeharrachaputi@gmail.com>
> ---
Thanks!
Acked-by: Dan Carpenter <error27@gmail.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-01 6:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-31 18:14 [PATCH] staging: pi433: Added information about bit_rate configuration Guru Mehar Rachaputi
2023-02-01 6:16 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox