From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jacopo Mondi <jacopo@jmondi.org>
Cc: Rui Miguel Silva <rmfrfs@gmail.com>,
slongerbeam@gmail.com, p.zabel@pengutronix.de,
shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
martin.kepplinger@puri.sm, xavier.roumegue@oss.nxp.com,
kernel@pengutronix.de, linux-imx@nxp.com,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c
Date: Mon, 14 Feb 2022 13:22:15 +0200 [thread overview]
Message-ID: <Ygo7Z9xz6eGd7STb@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220214112000.y7npvxtxoot26753@uno.localdomain>
Hi Jacopo,
On Mon, Feb 14, 2022 at 12:20:00PM +0100, Jacopo Mondi wrote:
> On Mon, Feb 14, 2022 at 10:20:57AM +0000, Rui Miguel Silva wrote:
> > Hey Jacopo,
> > I think you by now saw the kernel test report.
> >
> > You miss the rename in the makefile also.
>
> Yes, that's pretty stupid sorry, I forgot to add the Makefile :(
>
> I'll fix in v2
>
> Laurent, do you want to squash 2/3 and 3/3 to have the symbols and the
> file rename in the same patch ?
I think I'd prefer that, but if it ends up being messy you can keep them
separate.
> > ------
> > Cheers,
> > Rui
> > On Fri Feb 11, 2022 at 6:02 PM WET, Jacopo Mondi wrote:
> >
> > > Rename the imx7-mipi-csis.c driver to remove the reference to i.MX7.
> > >
> > > The driver is for an IP core found on i.MX7 and i.MX8 SoC so do not
> > > specify a SoC version number in the driver name.
> > >
> > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
> > > ---
> > > MAINTAINERS | 2 +-
> > > .../media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} | 0
> > > 2 files changed, 1 insertion(+), 1 deletion(-)
> > > rename drivers/media/platform/imx/{imx7-mipi-csis.c => imx-mipi-csis.c} (100%)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 5bdb8c881b0b..7def3b7d56bc 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -11891,7 +11891,7 @@ T: git git://linuxtv.org/media_tree.git
> > > F: Documentation/admin-guide/media/imx7.rst
> > > F: Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml
> > > F: Documentation/devicetree/bindings/media/nxp,imx7-mipi-csi2.yaml
> > > -F: drivers/media/platform/imx/imx7-mipi-csis.c
> > > +F: drivers/media/platform/imx/imx-mipi-csis.c
> > > F: drivers/staging/media/imx/imx7-media-csi.c
> > >
> > > MEDIA DRIVERS FOR HELENE
> > > diff --git a/drivers/media/platform/imx/imx7-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c
> > > similarity index 100%
> > > rename from drivers/media/platform/imx/imx7-mipi-csis.c
> > > rename to drivers/media/platform/imx/imx-mipi-csis.c
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-02-14 11:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 18:02 [PATCH 0/3] media: De-stage imx7-mipi-csis.c Jacopo Mondi
2022-02-11 18:02 ` [PATCH 1/3] media: imx: De-stage imx7-mipi-csis Jacopo Mondi
2022-02-11 18:32 ` Fabio Estevam
2022-02-11 20:21 ` Laurent Pinchart
2022-02-14 9:23 ` Jacopo Mondi
2022-02-14 11:40 ` Fabio Estevam
2022-02-11 20:40 ` Laurent Pinchart
2022-02-14 9:43 ` (EXT) " Alexander Stein
2022-02-14 9:51 ` Laurent Pinchart
2022-02-11 18:02 ` [PATCH 2/3] media: imx: Rename imx7-mipi-csis.c to imx-mipi-csis.c Jacopo Mondi
2022-02-11 20:42 ` Laurent Pinchart
2022-02-14 10:28 ` Rui Miguel Silva
2022-02-11 22:15 ` kernel test robot
2022-02-11 23:57 ` kernel test robot
2022-02-14 10:20 ` Rui Miguel Silva
2022-02-14 11:20 ` Jacopo Mondi
2022-02-14 11:22 ` Laurent Pinchart [this message]
2022-02-11 18:02 ` [PATCH 3/3] media: imx: Remove reference to i.MX7 from driver Jacopo Mondi
2022-02-11 20:46 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ygo7Z9xz6eGd7STb@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=festevam@gmail.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo@jmondi.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin.kepplinger@puri.sm \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rmfrfs@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
--cc=xavier.roumegue@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox