From: Greg KH <gregkh@linuxfoundation.org>
To: Joash Naidoo <joash.n09@gmail.com>
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
paskripkin@gmail.com, dan.carpenter@oracle.com,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v3] staging: r8188eu: fix too many leading tabs
Date: Sat, 24 Sep 2022 13:04:24 +0200 [thread overview]
Message-ID: <Yy7kON0jNecPXN/k@kroah.com> (raw)
In-Reply-To: <20220919132310.1494-1-joash.n09@gmail.com>
On Mon, Sep 19, 2022 at 03:23:10PM +0200, Joash Naidoo wrote:
> Coding style fix. Fix too many leading tabs and line length.
>
> Signed-off-by: Joash Naidoo <joash.n09@gmail.com>
> ---
> Changes in v3:
> - Fix flipped condition mistake
> - move skb NULL check before dereferencing it
> Changes in v2:
> - Flip additional nested if conditions and don't reverse the last if statement
> - Move declarations to start of function
> - Separate converting __constant_htons to htons to another patch
Always test-build your changes before sending them out so you do not get
grumpy emails from maintainers asking why you didn't test-build your
changes...
thanks,
greg k-h
next prev parent reply other threads:[~2022-09-24 11:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 13:23 [PATCH v3] staging: r8188eu: fix too many leading tabs Joash Naidoo
2022-09-24 11:04 ` Greg KH [this message]
2022-09-27 6:24 ` Joash Naidoo
2022-09-27 7:04 ` Michael Straube
2022-09-27 7:05 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yy7kON0jNecPXN/k@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=dan.carpenter@oracle.com \
--cc=joash.n09@gmail.com \
--cc=linux-staging@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox