Re: [PATCH v3] staging: r8188eu: fix too many leading tabs

[Dan Carpenter <dan.carpenter@oracle.com>]

On Tue, Sep 27, 2022 at 08:24:01AM +0200, Joash Naidoo wrote:
> 
> Greg KH <gregkh@linuxfoundation.org> writes:
> 
> > On Mon, Sep 19, 2022 at 03:23:10PM +0200, Joash Naidoo wrote:
> > > Coding style fix. Fix too many leading tabs and line length.
> > > 
> > > Signed-off-by: Joash Naidoo <joash.n09@gmail.com>
> > > ---
> > > Changes in v3:
> > >     - Fix flipped condition mistake
> > >     - move skb NULL check before dereferencing it
> > > Changes in v2:
> > >     - Flip additional nested if conditions and don't reverse     the
> > > last if statement
> > >     - Move declarations to start of function
> > >     - Separate converting __constant_htons to htons to another
> > > patch
> > 
> > Always test-build your changes before sending them out so you do not get
> > grumpy emails from maintainers asking why you didn't test-build your
> > changes...
> > 
> > thanks,
> > 
> > greg k-h
> Hi Greg,
> 
> Indeed building and testing is a vital step before sending
> changes. Is this message referring to my V3 patch not building? Or
> referring to my earlier versions?
> 
> Before sending I built my changes with:
> 
> make M=drivers/staging/r8188eu clean
> make M=drivers/staging/r8188eu
> 

  CC [M]  drivers/staging/r8188eu/core/rtw_br_ext.o
drivers/staging/r8188eu/core/rtw_br_ext.c: In function ‘dhcp_flag_bcast’:
drivers/staging/r8188eu/core/rtw_br_ext.c:607:9: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
  607 |         __be16 protocol = *((__be16 *)(skb->data + 2 * ETH_ALEN));
      |         ^~~~~~
cc1: all warnings being treated as errors

regards,
dan carpenter